Skip to content

allow for sni enabled endpoints re issue #337 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clatko wants to merge 3 commits into
base: master
Choose a base branch
from
Open

allow for sni enabled endpoints re issue #337 #391

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152b491
allow for sni enabled endpoints re issue #337
clatko Nov 14, 2018
83fb597
add logger; allow for multiple hosts to be sent via sni
clatko Dec 26, 2018
35d53b7
fix logger
clatko Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...nsport/src/main/java/com/netflix/ribbon/transport/netty/http/LoadBalancingHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,12 @@
import io.reactivex.netty.protocol.http.client.HttpClientResponse;
import io.reactivex.netty.servo.http.HttpClientListener;

import java.net.MalformedURLException;
import java.net.URI;
import java.net.URL;
import java.net.URISyntaxException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Map;
Expand All @@ -48,7 +52,10 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;

import javax.net.ssl.SNIHostName;
import javax.net.ssl.SNIServerName;
import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLParameters;

import rx.Observable;
import rx.functions.Func1;
Expand Down Expand Up @@ -511,6 +518,23 @@ protected HttpClient<I, O> createRxClient(Server server) {
@Override
public SSLEngine createSSLEngine(ByteBufAllocator allocator) {
SSLEngine myEngine = super.createSSLEngine(allocator);

URL url = null;
if(null!=getRxClients()) {
try {
Server server = getRxClients().entrySet().iterator().next().getKey();
Copy link
Copy Markdown

@yyvess yyvess Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dough that is correct to get only the first one

Copy link
Copy Markdown
Author

@clatko clatko Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gather all hosts

url = new URL(server.getScheme() + "://" + server.getHost());

SSLParameters sslParameters = new SSLParameters();
List<SNIServerName> sniServerNames = new ArrayList<>();
sniServerNames.add(new SNIHostName(url.getHost()));
sslParameters.setServerNames(sniServerNames);
myEngine.setSSLParameters(sslParameters);
} catch (MalformedURLException e) {
e.printStackTrace();
Copy link
Copy Markdown

@yyvess yyvess Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a logger

Copy link
Copy Markdown
Author

@clatko clatko Dec 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added logger

}
}

myEngine.setUseClientMode(true);
return myEngine;
}
Expand Down