Repository navigation
chart: fix division by zero and step overflow in json engine - #2011
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
In JsonGraphEngine, graphDatapoints was calculated by dividing (config.step / 1000). For sub-second step sizes (such as 500ms or 100ms, supported in Step.allowedStepSizes), integer division evaluates to 0 and throws ArithmeticException: / by zero. Using config.step directly in milliseconds avoids division by zero while preserving the exact datapoint count. Additionally, step was cast to Int, which overflows for large step intervals (> 24.8 days) and causes timestamp += step to decrease in an infinite loop. Keep step as Long. Also add unit test coverage for stats.json and ensure test string stripping is newline-agnostic. Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two edge-case issues in JsonGraphEngine:
Verification
All 335 tests in atlas-chart pass: