Repository navigation
core: restrict :named-rewrite name to known words - #2008
Merged
Merged
Conversation
The name of a named rewrite is rendered as `:$name` and the display expression is executed again when the expression is rewritten, for example when HostRewriter adds a restriction. Escaped commas in the name were a single token on the first parse, but became separate operations on the second, allowing arbitrary operations to be injected that could drop the added restriction. Require the name to be a word in the vocabulary. The re-execution runs with unstable features enabled, so the name must also be a stable word unless the caller enabled unstable features. Otherwise the rewrite could bypass the feature gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of a named rewrite is rendered as
:$nameand the display expression is executed again when the expression is rewritten, for example when HostRewriter adds a restriction. Escaped commas in the name were a single token on the first parse, but became separate operations on the second, allowing arbitrary operations to be injected that could drop the added restriction. Require the name to be a word in the vocabulary.The re-execution runs with unstable features enabled, so the name must also be a stable word unless the caller enabled unstable features. Otherwise the rewrite could bypass the feature gate.