Repository navigation
pekko: honor standalone config for access log - #2007
Merged
Merged
Conversation
AccessLogger and Cors read their settings from ConfigManager.get(), the static config loaded from the classpath. The standalone main applies the config files passed on the command line as overrides on the dynamic config, so settings such as the sensitive headers to redact from the access log were silently ignored when set that way. Read from ConfigManager.dynamicConfig() instead. The standalone main also called setOverrideConfig once per file, but each call replaces the previous override, so only the last file was used. Merge the files and set the override once. Header names to redact are now trimmed before matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccessLogger and Cors read their settings from ConfigManager.get(), the static config loaded from the classpath. The standalone main applies the config files passed on the command line as overrides on the dynamic config, so settings such as the sensitive headers to redact from the access log were silently ignored when set that way. Read from ConfigManager.dynamicConfig() instead.
The standalone main also called setOverrideConfig once per file, but each call replaces the previous override, so only the last file was used. Merge the files and set the override once.
Header names to redact are now trimmed before matching.