Use encodedQuery for deep link URLs in MainActivity#152
Open
blessedzulu wants to merge 1 commit into
Open
Conversation
uri.query returns the decoded query string, which corrupts URL-encoded parameters (e.g. bracketed array keys like foo[0][bar]) when the deep link URL is rebuilt and reloaded into the WebView. Use encodedQuery to preserve the original encoding, matching the queryString handling already used in PHPWebViewClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleDeepLinkIntentbuilds the in-app URL fromuri.query, which returns the decoded query string. That corrupts URL-encoded parameters - e.g. bracketed array keys likefoo[0][bar](how Livewire serialises array#[Url]props) - when the URL is rebuilt and reloaded into the WebView, so those params arrive empty on deep-linked pages while plain scalars survive.Switching to
uri.encodedQuerypreserves the original encoding. This matches thequeryString = request.url.encodedQueryhandling already onmaininPHPWebViewClient; this just applies the same to the two URL builders inMainActivity(universal link + FCM).