You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes include, Migrating from winapi to windows-sys: winapi is no longer maintained in favor of windows-rs which is provided by Microsoft itself. It should provide more robustness against future windows upgrade and better compile and runtime guarantees.
This PR looks much cleaner to me, as the type changes do stand out much more than they used to.
They still feel weird, but are necessary since they are differences in the original crates..
As I mentioned in the previous PR, I'm unlikely to merge before having checked extensively this (which I can't promise will happen any time soon).
If anyone happens to take this PR out for a spin and it works (or has bugs) it would be nice to share here (if many people report it's working, I'll take that as a good sign, and maybe not test as much and merge earlier).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes include, Migrating from
winapitowindows-sys:winapiis no longer maintained in favor ofwindows-rswhich is provided by Microsoft itself. It should provide more robustness against future windows upgrade and better compile and runtime guarantees.This is the continuation of #97
cargoprofile changes, they are overwritten by end binary.gitignore, so that's a pretty good thing to learnmod.rsas publicHOOK, aren't we modifying it atset_key_hook&set_mouse_hook