Repository navigation
feat: corner defaults can be replaced; center the collapsible demo - #36
Merged
Merged
Conversation
- app-shell: the four corner jobs are defaults; `corners` replaces any corner, and CornerLink / CornerTip are exported so custom content keeps the corner look; breadcrumb is optional - collapsible demo: trigger and panel center, so opening no longer moves the trigger left Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app-shell: the corner jobs (breadcrumb, nav, member + theme, copyright) become defaults.corners={{ topLeft?, topRight?, bottomLeft?, bottomRight? }}replaces any corner;CornerLinkandCornerTipare exported so custom content keeps the corner type, color and tips.breadcrumbis optional. DESIGN.md calls the table default jobs.items-center text-center, so the trigger stays put when the panel opens (it jumped left because the opened block was wider than the trigger).Test plan
corners.topRightandcorners.bottomRight: both replaced, top left kept its default (page removed before commit)/collapsible: trigger x 580 before and after opening; no console errors🤖 Generated with Claude Code