Repository navigation
feat: publish combobox with the select's field trigger - #28
Merged
Merged
Conversation
The combobox demo used an outline button as its trigger, so in dark mode it had the page background, a border-colored outline and 16px padding, unlike the inputs and select around it. - field (registry:lib): one class list for every pick-a-value trigger; select now uses it - combobox: ComboboxTrigger (field look, placeholder) and ComboboxContent (as wide as the trigger) around a Command; single or multiple choice is up to the Command - tokens:check treats all of registry/winlab as component code - DESIGN.md: never use a button as a field Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attendee picker used an outline
Buttonas its trigger, so it did not match the fields around it (dark mode: page background instead ofbg-input/30,border-borderinstead ofborder-input, 16px instead of 12px padding).field(registry:lib):fieldTriggerClassName, the closed look of every pick-a-value control.selectuses it.combobox:ComboboxTrigger(field look,placeholderprop) andComboboxContent(w-(--anchor-width)), composed withPopoverandCommand. Portal's five pickers are multi-select with groups, so these stay pieces rather than one closed component.tokens:check: all ofregistry/winlabis component code (the lib file was linted as a page).Test plan
shadcn add combobox selectwriteslib/field.ts, imports rewrite to@/lib/field, build passes🤖 Generated with Claude Code