Repository navigation
Keep the shared Java facade compatible with Java 8 - #40
Open
NV-sschneider wants to merge 1 commit into
Open
NV-sschneider wants to merge 1 commit into
NV-sschneider wants to merge 1 commit into
Conversation
Replace the command-line redactor records with immutable holders and append backslashes without StringBuilder.repeat. Compile every shared facade source against the Java 8 platform in a regression test with only JOML on the classpath. Signed-off-by: Seth Schneider <74025139+NV-sschneider@users.noreply.github.com>
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared facade cannot compile on Java 8 because
CommandLineRedactionuses records andStringBuilder.repeat. Replace the two record holders with immutable classes and append backslashes in a loop. This is a small prerequisite for reusing the facade from Forge 1.12.2.Add a regression test that compiles all shared facade sources against the Java 8 platform, with only JOML on the classpath. It runs in the existing test suite. The public facade API and native runtime contract are unchanged.
Validation:
gradlew.bat build test: 800 tests passed, no skips.tools\rtx.bat check --tests: formatting, lint, types, public-boundary checks, 1,135 tests and 178 subtests passed.tools\rtx.bat launch --resource-pack none --quiet: authenticated Windows x64 Fabric launch; inspected the title screen, confirmed Remix initialization, then quit normally with clean runtime shutdown.