Set PR Roadmap from target branch when merged by YanxuanLiu · Pull Request #59 · NVIDIA/spark-rapids-common

YanxuanLiu · 2026-08-13T05:27:25Z

Summary

preserve the existing behavior that adds issues and pull requests to the configured GitHub Project
for merged pull requests in NVIDIA/cudf-spark and NVIDIA/cudf-spark-jni, read the root pom.xml at the event's immutable merged-result SHA and derive the YY.MM release
set the Project Roadmap field only when it is empty, preserving existing values and re-checking immediately before the update
report missing or ambiguous POM versions and Roadmap options without assigning a value

Why

Roadmap should reflect the release branch at merge time. A pull request that stays open across release cycles is therefore assigned from the branch state it actually merges into, rather than from its state when opened.

Consumer workflow updates add the merged closed event while continuing to add issues and pull requests on opened:

Validation

Python 3.9 and 3.14 syntax checks
14 focused tests covering add-only behavior for opened/unmerged events, both target repositories on merge, existing values and the final pre-update re-check, merged-result SHA POM reads, malformed or ambiguous versions, and missing or duplicate options
git diff --check

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

Copilot

Pull request overview

This PR replaces the previous actions/github-script implementation of the add-to-project composite action with a Python-based implementation that can optionally derive and set the GitHub Project “Roadmap” field for PRs in NVIDIA/cudf-spark and NVIDIA/cudf-spark-jni by reading the target branch root pom.xml at the immutable base SHA.

Changes:

Replaced the composite action step from actions/github-script@v8 to a Python runner invoking add_to_project.py.
Added add_to_project.py to (1) add issues/PRs to the configured GitHub Project and (2) auto-populate “Roadmap” from the target branch pom.xml for the specified repositories, only when the field is currently empty.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
add-to-project/add_to_project.py	New standard-library GitHub REST/GraphQL client and Roadmap auto-population logic based on target-branch `pom.xml`.
add-to-project/action.yml	Switches the composite action implementation from `github-script` to running the new Python script with the provided token.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

greptile-apps · 2026-08-13T07:07:06Z

Greptile Summary

The PR replaces the JavaScript-based composite-action implementation with a Python GitHub API client that preserves project membership and derives merged pull requests’ Roadmap values from the target branch POM.

Adds robust REST and GraphQL response validation and project-item lookup.
Reads and validates the root POM at the merged-result SHA for supported repositories.
Preserves existing Roadmap values and refreshes the field immediately before updating it.
Updates the action’s token requirements and invokes the new Python entry point.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
add-to-project/action.yml	Replaces actions/github-script with the Python implementation and exposes the token through GH_TOKEN.
add-to-project/add_to_project.py	Implements project-item management, merged-result POM parsing, release-option resolution, and best-effort Roadmap preservation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[GitHub event] --> B[Load issue or pull request]
  B --> C[Find configured Project V2]
  C --> D{Item already in project?}
  D -- No --> E[Add project item]
  D -- Yes --> F[Reuse existing item]
  E --> G{Merged PR in supported repository?}
  F --> G
  G -- No --> H[Finish]
  G -- Yes --> I{Roadmap already set?}
  I -- Yes --> H
  I -- No --> J[Read root POM at merge-result SHA]
  J --> K[Derive YY.MM and resolve option]
  K --> L[Refresh Roadmap]
  L --> M{Still empty?}
  M -- No --> H
  M -- Yes --> N[Set Roadmap option]
  N --> H

_{Reviews (6): Last reviewed commit: "Keep Roadmap fix minimal" | Re-trigger Greptile}

NvTimLiu · 2026-08-13T08:30:46Z

+    return base_ref, base_sha, pom_xml
+
+
+def populate_roadmap(client, repository, pull_request, project, item):


The function body never references pull_request, can it be removed?

yes, removed.

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

NvTimLiu · 2026-08-13T08:57:33Z

One more concern: the “add to project” workflow runs only on GitHub’s [open] event.

This is currently sufficient for spark-rapids, because project membership does not need to change between release cycles.

However, if a PR remains open from 26.10 until 27.10, the Roadmap should be determined when the PR is merged. In that case, it should be set to 27.10, not 26.10.

Ideally, the Roadmap should be set by the GitHub Actions workflow when the PR is merged.

YanxuanLiu · 2026-08-13T09:16:25Z

One more concern: the “add to project” workflow runs only on GitHub’s [open] event.

This is currently sufficient for spark-rapids, because project membership does not need to change between release cycles.

However, if a PR remains open from 26.10 until 27.10, the Roadmap should be determined when the PR is merged. In that case, it should be set to 27.10, not 26.10.

Ideally, the Roadmap should be set by the GitHub Actions workflow when the PR is merged.

Thanks, that makes sense. I propose keeping opened only for adding the PR to the Project, then setting Roadmap on closed only when the PR was merged.
At merge time, if Roadmap is empty, derive it from the target branch POM. If it was already set manually or by another automation, preserve it. Does that match the expected behavior?

NvTimLiu · 2026-08-14T04:43:00Z

One more concern: the “add to project” workflow runs only on GitHub’s [open] event.
This is currently sufficient for spark-rapids, because project membership does not need to change between release cycles.
However, if a PR remains open from 26.10 until 27.10, the Roadmap should be determined when the PR is merged. In that case, it should be set to 27.10, not 26.10.
Ideally, the Roadmap should be set by the GitHub Actions workflow when the PR is merged.

Thanks, that makes sense. I propose keeping opened only for adding the PR to the Project, then setting Roadmap on closed only when the PR was merged. At merge time, if Roadmap is empty, derive it from the target branch POM. If it was already set manually or by another automation, preserve it. Does that match the expected behavior?

Make sense

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

greptile-apps · 2026-08-14T08:24:51Z

Want your agent to iterate on Greptile's feedback? Try greploops.

YanxuanLiu · 2026-08-14T09:58:25Z

One more concern: the “add to project” workflow runs only on GitHub’s [open] event.
This is currently sufficient for spark-rapids, because project membership does not need to change between release cycles.
However, if a PR remains open from 26.10 until 27.10, the Roadmap should be determined when the PR is merged. In that case, it should be set to 27.10, not 26.10.
Ideally, the Roadmap should be set by the GitHub Actions workflow when the PR is merged.

Thanks, that makes sense. I propose keeping opened only for adding the PR to the Project, then setting Roadmap on closed only when the PR was merged. At merge time, if Roadmap is empty, derive it from the target branch POM. If it was already set manually or by another automation, preserve it. Does that match the expected behavior?

Make sense

Updated and tested in my personal repo for both opened and closed behaviours

NvTimLiu

LGTO, +1

## Summary - keep adding issues and pull requests to the NVIDIA Project when they are opened - also run the shared action when a pull request is closed and merged - skip pull requests that are closed without merging - use `spark-rapids-common/add-to-project@main` ## Behavior After NVIDIA/spark-rapids-common#59 is merged, the shared action adds the PR to the Project on `opened`, but only derives and sets `Roadmap` on the merged `closed` event. If `Roadmap` was assigned manually before merge, it is preserved. ## Testing note This is a draft integration PR and depends on NVIDIA/spark-rapids-common#59. `pull_request_target` uses the workflow from the base repository's default branch, so this PR's new `closed` trigger will not execute until the workflow change exists on the default branch. ## Validation - YAML parsed successfully - `git diff --check` - event-condition review: issue opened and PR opened run; merged PR runs; closed-unmerged PR is skipped Common action PR: NVIDIA/spark-rapids-common#59 --------- Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

Auto-set PR Roadmap from pom.xml

a7bcd06

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

YanxuanLiu mentioned this pull request Aug 13, 2026

Run Roadmap automation when pull requests merge NVIDIA/cudf-spark#15650

Closed

YanxuanLiu requested a lite review from Copilot August 13, 2026 07:03

YanxuanLiu marked this pull request as ready for review August 13, 2026 07:03

YanxuanLiu requested a review from a team as a code owner August 13, 2026 07:04

YanxuanLiu requested review from NvTimLiu and yinqingh August 13, 2026 07:04

Copilot started reviewing on behalf of YanxuanLiu August 13, 2026 07:04 View session

Copilot AI reviewed Aug 13, 2026

View reviewed changes

Comment thread add-to-project/action.yml

Comment thread add-to-project/add_to_project.py

greptile-apps Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread add-to-project/add_to_project.py

Comment thread add-to-project/add_to_project.py

NvTimLiu reviewed Aug 13, 2026

View reviewed changes

Remove unused pull request argument

53b9574

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

Set Roadmap when pull requests merge

b479bd9

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

YanxuanLiu mentioned this pull request Aug 14, 2026

Run Roadmap automation when pull requests merge [skip ci] NVIDIA/cudf-spark-jni#5000

Merged

YanxuanLiu changed the title ~~Auto-set PR Roadmap from target branch pom.xml~~ Set PR Roadmap from target branch when merged Aug 14, 2026

YanxuanLiu mentioned this pull request Aug 14, 2026

Run Roadmap automation when pull requests merge [skip ci] NVIDIA/cudf-spark#15674

Merged

8 tasks

YanxuanLiu added 2 commits August 14, 2026 16:13

Handle existing project items on merge

8f2200e

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

Keep Roadmap fix minimal

1defcec

Signed-off-by: YanxuanLiu <yanxuanl@nvidia.com>

YanxuanLiu marked this pull request as draft August 14, 2026 08:32

YanxuanLiu marked this pull request as ready for review August 14, 2026 09:57

NvTimLiu approved these changes Aug 17, 2026

View reviewed changes

YanxuanLiu merged commit 41881c0 into main Aug 17, 2026
5 checks passed

Navigation Menu

Uh oh!

Set PR Roadmap from target branch when merged - #59

Set PR Roadmap from target branch when merged#59
YanxuanLiu merged 5 commits into
mainfrom
auto-roadmap-from-pom

YanxuanLiu commented Aug 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

NvTimLiu Aug 13, 2026

Uh oh!

YanxuanLiu Aug 13, 2026

Uh oh!

NvTimLiu commented Aug 13, 2026

Uh oh!

YanxuanLiu commented Aug 13, 2026

Uh oh!

NvTimLiu commented Aug 14, 2026

Uh oh!

greptile-apps Bot commented Aug 14, 2026

Uh oh!

YanxuanLiu commented Aug 14, 2026

Uh oh!

NvTimLiu left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		return base_ref, base_sha, pom_xml


		def populate_roadmap(client, repository, pull_request, project, item):

Uh oh!

Conversation

YanxuanLiu commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

NvTimLiu Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

YanxuanLiu Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

NvTimLiu commented Aug 13, 2026

Uh oh!

YanxuanLiu commented Aug 13, 2026

Uh oh!

NvTimLiu commented Aug 14, 2026

Uh oh!

greptile-apps Bot commented Aug 14, 2026

Uh oh!

YanxuanLiu commented Aug 14, 2026

Uh oh!

NvTimLiu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YanxuanLiu commented Aug 13, 2026 •

edited

Loading

greptile-apps Bot commented Aug 13, 2026 •

edited

Loading