Update shared actions to Node 24 for GitHub Actions Node 20 deprecation - #54
Conversation
Signed-off-by: Peixin Li <pxLi@nyu.edu>
Greptile SummaryThis PR updates three shared GitHub Actions composite actions from Node 20 to Node 24 runtimes to address GitHub's Node 20 deprecation. The changes are:
The migration is well-motivated and the inline GraphQL replacement for Confidence Score: 4/5Safe to merge after addressing the null-dereference in the add-to-project GraphQL script. The PR is well-structured and verified working in a fork. However, the missing null-check on
Important Files Changed
Sequence DiagramsequenceDiagram
participant W as Calling Workflow
participant A as add-to-project/action.yml
participant GH as GitHub GraphQL API
W->>A: inputs: token, project-url
A->>A: Parse project URL (regex)
A->>GH: query organization/user projectV2(number)
GH-->>A: { projectV2: { id } } or null
Note over A: ⚠️ Missing null-check here
A->>GH: query context.payload issue/PR node_id
A->>GH: mutation addProjectV2ItemById
GH-->>A: { item: { id } }
A->>W: core.info("Added to project …")
Reviews (1): Last reviewed commit: "Update all common actions to use node24 ..." | Re-trigger Greptile |
fix #53
Changes
checkout/action.ymlactions/checkout@v4(Node 20)actions/checkout@v6(Node 24)pr-description-check/action.ymlactions/github-script@v7(Node 20)actions/github-script@v8(Node 24)add-to-project/action.ymlactions/add-to-project@v1.0.2(Node 20, unmaintained)actions/github-script@v8(Node 24)Verified in forked repo,
https://github.com/pxLi/spark-rapids-common/actions/runs/23777336303/job/69282009121?pr=7