Add nvidia-skill-finder as catalog-only router skill#340
Conversation
Stage the skill directly under skills/nvidia-skill-finder/ per catalog infra guidance — no components.d upstream. Register it in catalog-exceptions.yml so sync pruning preserves the directory. Signed-off-by: Jason Dudash <jdudash@nvidia.com>
|
/nvskills-ci |
There was a problem hiding this comment.
Reviewed — the skill and the wiring are in great shape; the blocker is upstream of this PR.
What's right: SKILL.md is a well-scoped router (rich positive triggers, explicit negative triggers, live-catalog-as-source-of-truth so it won't rot), full artifact set (evals, skill card, benchmark), catalog-exceptions.yml entry is textbook (dir/reason/owner/component — the pruner will preserve it and the dashboard groups it), and the committed benchmarks.json regen passes the drift gate. Also the right call replacing the fork PR — in-repo branch is what the signing service needs.
Blocker: the signing run needs to complete before merge — per catalog rules, no merge until skill.oms.sig and the refreshed skill card land.
One naming note, non-blocking: component: NVIDIA Skills creates a new product grouping on the adoption dashboard — intentional for catalog-infrastructure skills? Fine either way, just confirming it's deliberate.
Once the signing run goes green here, I'm ready to approve same-day.
Surface activation constraints and an install-confirmation guardrail in agents/openai.yaml so implicit invocation is explicitly scoped (addresses the SkillSpector elevation-of-privilege finding while keeping the router's implicit-invocation behavior). De-duplicate the false-positive guidance: keep SKILL.md "When Not to Use this Skill" as authoritative and replace the overlapping section in references/taxonomy-routing.md with a pointer. Signed-off-by: Jason Dudash <jdudash@nvidia.com>
|
/nvskills-ci |
Keep the OpenAI adapter metadata minimal while documenting implicit invocation scope and install consent in the skill instructions where agent behavior is specified. Signed-off-by: Jason Dudash <jdudash@nvidia.com>
|
/nvskills-ci |
Reword the implicit-invocation constraints so they scope activation to NVIDIA relevance without raising the trigger bar above the original "plausibly related" threshold, and separate recommendation (always allowed) from installation (requires explicit user approval). Avoids underfiring on softer NVIDIA-adjacent requests. Signed-off-by: Jason Dudash <jdudash@nvidia.com>
|
/nvskills-ci |
|
cc @mosheabr — heads-up on the changes here Context
Findings and fixes1. DUPLICATE (tier2, HIGH, conf 0.88) —
2. SECURITY (tier1, HIGH, conf 0.72) — SkillSpector flagged
|
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Summary
skills/nvidia-skill-finder/directly to the catalog as a router/discovery skill (nocomponents.dupstream)catalog-exceptions.ymlso the current orphan-pruning sync logic preserves this catalog-only skillbenchmarks.jsonfrom the stagedBENCHMARK.mdThis follows Moshe's guidance that the skill belongs in the catalog itself rather than as a synced component. Because newer sync logic prunes unregistered
skills/directories, this PR explicitly addsnvidia-skill-findertocatalog-exceptions.yml. Future updates are direct PRs here plus a fresh/nvskills-cirun.Replaces fork PR #339 because
/nvskills-cidoes not support fork pull requests; the signing service needs to push the signature commit back to a branch insideNVIDIA/skills.Sync and signing notes
components.dentry is added, so normal rsync sync will not overwrite this skill.catalog-exceptions.ymlprotects it from orphan pruning.skill.oms.sig,skill-card.md, and eval data./nvskills-cishould generate the signature commit and refresh generated artifacts. Before merge, verify that commit landed and that no unsigned content commit came after it.benchmarks.jsonis regenerated fromBENCHMARK.md. If/nvskills-cirewritesBENCHMARK.md, re-runaggregate_benchmarks.pysobenchmarks.jsonstill matches and the metadata check stays green.Follow-up
/nvskills-cichecks pass and this merges, we will create a separate PR to includenvidia-skill-finderin the plugin bundle.Post-merge checklist
/nvskills-cion this PR (maintainer/admin) to generateskill.oms.sig, refreshskill-card.md, and regenerateBENCHMARK.mdTest plan
/nvskills-cicompletes and pushes signature commitskill.oms.sig,skill-card.md, andevals/evals.jsonpresent after CIbenchmarks.jsonre-verified against the post-/nvskills-ciBENCHMARK.mdnpx skills add nvidia/skills --skill nvidia-skill-finder --listshows the skill after merge