Update NSVHMEM block for new releases on Github#538
Update NSVHMEM block for new releases on Github#538mhrywniak wants to merge 2 commits intoNVIDIA:masterfrom
Conversation
Releases >= 3.4.5 are published on Github, ensure they get picked up. Fix `mpi` arg to allow using either True or an explicit MPI_HOME
samcmill
left a comment
samcmill
left a comment
There was a problem hiding this comment.
Would you please add a test case for version 3.4.5 to exercise the new behavior?
| self.__cmake_opts.append('-DNVSHMEM_MPI_SUPPORT=1') | ||
| self.__cmake_opts.append('-DMPI_HOME={}'.format(self.__mpi)) | ||
| #else: | ||
| # self.__cmake_opts.append('-DNVSHMEM_MPI_SUPPORT=0') |
There was a problem hiding this comment.
Is the else branch still needed? Or does NVSHMEM now default to that case?
There was a problem hiding this comment.
Good point - I will double-check the default, but I think the else can go away.
|
@jilliebean @sopcao for viz |
|
Also, since you updated the docstring, the docs will need to be regenerated. I can do that post-merge since it requires having |
|
Thanks for the review! I will likely get around to implementing this on Monday.
I can also regenerate this, but |
2 participants
Releases >= 3.4.5 are published on Github, ensure they get picked up. Fix
mpiarg to allow using either True or an explicit MPI_HOME.I could not run the
pydocmd generatecommand, do I need a different package?uvx -p 3.11 -w pydoc-markdown pydocmd generateseems to expect a .py file instead, and with newer Python versions I get errors about the deprecated/removedimppackage.Pull Request Description
Author Checklist
pydocmd generate) if any docstrings have been modified