Conversation
Resolves NVIDIA#2884 A package repository on the node's own disk cannot be used today: a "file:///opt/local-packages" URI supplied via driver.repoConfig does not resolve inside the driver container, and there is no supported way to expose the host directory to it. Add an optional nodeLocalPaths list to the existing repoConfig API on both ClusterPolicy and NVIDIADriver. Each entry is bind-mounted read-only into the driver container at the same path, so file:// URIs resolve identically on the host and in the container. Paths are validated as clean, absolute and non-root, then deduplicated and sorted so volume naming is deterministic. Defaults to empty, is ignored for precompiled drivers to match configMapName, and is rejected when set without a repo ConfigMap. Signed-off-by: Nikhil R Deshpande <nikhil-nd.deshpande@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2884
Description
A package repository on the node's own disk cannot be used today: a "file:///opt/local-packages" URI supplied via
driver.repoConfigdoes not resolve inside the driver container, and there is no supported way to expose the host directory to it.Add an optional
nodeLocalPathslist to the existingrepoConfigAPI on bothClusterPolicyandNVIDIADriver. Each entry is bind-mounted read-only into the driver container at the same path, sofile://URIs resolve identically on the host and in the container. Paths are validated as clean, absolute and non-root, then deduplicated and sorted so volume naming is deterministic.Defaults to empty, is ignored for precompiled drivers to match configMapName, and is rejected when set without a repo ConfigMap.
Example usage:
GPU Operator configuration snippet:
with Kubernetes configmap
local-package-repocontent as:The k8s node has the repo stored at node file system at
/opt/local-packages(and has the deb packages for kernel-headers, other necessary packages needed by Nvidia driver container install script).Checklist
make lint)make validate-generated-assets)make validate-modules)Testing