Skip to content

bump nvidia-container-toolkit to 1.20.1-rc.1 - #2897

Merged
cdesiniotis merged 1 commit into
NVIDIA:mainfrom
cdesiniotis:bump-toolkit-1.20.1-rc.1
Sep 14, 2026
Merged

cdesiniotis merged 1 commit into
NVIDIA:mainfrom
cdesiniotis:bump-toolkit-1.20.1-rc.1

Conversation

@cdesiniotis

Copy link
Copy Markdown
Contributor

Description

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

📝 Walkthrough

Walkthrough

The change updates nvidia-container-toolkit to a September 2026 pseudo-version. It adds moby/sys/devices and upgrades opencontainers/cgroups and golang.org/x/sys indirect dependencies.

Priority: ⬇️ Low

Merge Risk: 🟡 Moderate · up to 53580

The selected toolkit version does not match the stated release-candidate target. Confirm the intended upstream version before merging so deployments receive the tested toolkit release.


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.

🟡 Other comments (1)
go.mod-10-10 (1)

10-10: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Align the toolkit target with an available upstream version.

If this PR must consume v1.20.1-rc.1, the dependency does not meet that target. The upstream repository has no v1.20.1-rc.1 tag, and replacing the pseudo-version with that tag would fail to resolve. Confirm whether the PR targets commit 24761af0847d0c4581b54de74b51b620b62bcda8 or another published version, then align the dependency and PR objective.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 4cceeecf-6f85-4975-8368-69cfc247aee9

📥 Commits

Reviewing files that changed from the base of the PR and between 7dd98e3 and 535800e.

⛔ Files ignored due to path filters (48)
  • go.sum is excluded by !**/*.sum, !go.sum
  • vendor/github.com/NVIDIA/nvidia-container-toolkit/internal/devices/devices.go is excluded by !vendor/**
  • vendor/github.com/NVIDIA/nvidia-container-toolkit/internal/nvcaps/nvcaps.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/devices/LICENSE is excluded by !vendor/**
  • vendor/github.com/moby/sys/devices/device_unix.go is excluded by !vendor/**
  • vendor/github.com/moby/sys/devices/doc.go is excluded by !vendor/**
  • vendor/github.com/opencontainers/runc/NOTICE is excluded by !vendor/**
  • vendor/github.com/opencontainers/runc/libcontainer/devices/device_deprecated.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ifreq_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ioctl_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/mkerrors.sh is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/syscall.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/syscall_bsd.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/syscall_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_386.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_amd64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_arm.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_loong64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_s390x.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_386.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_amd64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_arm.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_arm64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_loong64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_s390x.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.go is excluded by !vendor/**
  • vendor/golang.org/x/sys/windows/types_windows.go is excluded by !vendor/**
  • vendor/modules.txt is excluded by !vendor/**
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@cdesiniotis
cdesiniotis force-pushed the bump-toolkit-1.20.1-rc.1 branch from 535800e to 163a623 Compare September 14, 2026 22:29
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@cdesiniotis
cdesiniotis force-pushed the bump-toolkit-1.20.1-rc.1 branch from 163a623 to f4ace16 Compare September 14, 2026 22:30
@cdesiniotis

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-26.7

@cdesiniotis
cdesiniotis merged commit 12771ed into NVIDIA:main Sep 14, 2026
21 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Backport PR created for release-26.7: #2898 ⚠️ (has conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants