bump nvidia-container-toolkit to 1.20.1-rc.1 - #2897
Conversation
📝 WalkthroughWalkthroughThe change updates Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to The selected toolkit version does not match the stated release-candidate target. Confirm the intended upstream version before merging so deployments receive the tested toolkit release. Comment |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (1)
go.mod-10-10 (1)
10-10: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAlign the toolkit target with an available upstream version.
If this PR must consume
v1.20.1-rc.1, the dependency does not meet that target. The upstream repository has nov1.20.1-rc.1tag, and replacing the pseudo-version with that tag would fail to resolve. Confirm whether the PR targets commit24761af0847d0c4581b54de74b51b620b62bcda8or another published version, then align the dependency and PR objective.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: QUIET
Plan: Enterprise
Run ID: 4cceeecf-6f85-4975-8368-69cfc247aee9
⛔ Files ignored due to path filters (48)
go.sumis excluded by!**/*.sum,!go.sumvendor/github.com/NVIDIA/nvidia-container-toolkit/internal/devices/devices.gois excluded by!vendor/**vendor/github.com/NVIDIA/nvidia-container-toolkit/internal/nvcaps/nvcaps.gois excluded by!vendor/**vendor/github.com/moby/sys/devices/LICENSEis excluded by!vendor/**vendor/github.com/moby/sys/devices/device_unix.gois excluded by!vendor/**vendor/github.com/moby/sys/devices/doc.gois excluded by!vendor/**vendor/github.com/opencontainers/runc/NOTICEis excluded by!vendor/**vendor/github.com/opencontainers/runc/libcontainer/devices/device_deprecated.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ifreq_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ioctl_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!vendor/**vendor/golang.org/x/sys/unix/syscall.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/syscall_bsd.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/syscall_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!vendor/**vendor/golang.org/x/sys/windows/types_windows.gois excluded by!vendor/**vendor/modules.txtis excluded by!vendor/**
📒 Files selected for processing (1)
go.mod
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.
535800e to
163a623
Compare
Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
163a623 to
f4ace16
Compare
|
/cherry-pick release-26.7 |
|
🤖 Backport PR created for |
Description
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing