fix(java): restore parquet writer factory compatibility - #24055
fix(java): restore parquet writer factory compatibility#24055victorwon2001 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesThe Parquet chunked writer factories now preserve Parquet writer factory API
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This restores the established Parquet writer API descriptors for existing binaries while providing dedicated footer-aware factories. The compatibility and footer-return contracts are covered, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Description
Restore the three
Table.writeParquetChunkedoverloads to their establishedTableWriterreturn type, restoring the JVM descriptors used by binaries compiled before #23912. Add matchingwriteParquetChunkedWithFooteroverloads returningParquetTableWriter, route the legacy factories through them, and move the footer-specific tests to the new API while adding return-type regression coverage.Binaries compiled against the short-lived #23912
ParquetTableWriterreturn descriptors are not simultaneously binary-compatible with the restored legacy descriptors and must be recompiled; callers that need the concrete writer should migrate towriteParquetChunkedWithFooter.Closes #23972
Java main/test compilation, JVM descriptor inspection, pre-commit, and diff validation passed. The focused native-backed Maven tests could not run because the environment has no
nvccor configured libcudf native build/install.Checklist