Skip to content

Remove skip for test_shuffle_group_by_reseed - #23121

Open
TomAugspurger wants to merge 3 commits into
NVIDIA:mainfrom
TomAugspurger:tom/unskip-groupby-reseed
Open

Remove skip for test_shuffle_group_by_reseed#23121
TomAugspurger wants to merge 3 commits into
NVIDIA:mainfrom
TomAugspurger:tom/unskip-groupby-reseed

Conversation

@TomAugspurger

Copy link
Copy Markdown
Contributor

Description

This was skipped in e5e329b. I'm testing whether recent changes have fixed this.

This was skipped in e5e329b. I'm testing whether recent changes have fixed
this.
@copy-pr-bot

copy-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

/ok to test 8e97c28

@TomAugspurger TomAugspurger added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 6, 2026
@TomAugspurger

Copy link
Copy Markdown
Contributor Author

test_shuffle_group_by_reseed did fail, so this is still an issue.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

xref #22964

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

/ok to test 06c2b0f

@TomAugspurger

TomAugspurger commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

CI passed in 06c2b0f. I suspect this was fixed by #24053 (cc @mroeschke)

I'll merge main to get another CI run, but IIRC this failed pretty reliably previously.

(edit: I should have just rerun the polars tests a few times rather than everything.)

@TomAugspurger
TomAugspurger marked this pull request as ready for review September 10, 2026 18:40
@TomAugspurger
TomAugspurger requested a review from a team as a code owner September 10, 2026 18:40
@TomAugspurger
TomAugspurger requested a review from bdice September 10, 2026 18:40
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9402043b-d201-4e22-81aa-f623f647dfab

📥 Commits

Reviewing files that changed from the base of the PR and between 9a8a250 and 06c2b0f.

📒 Files selected for processing (1)
  • ci/run_cudf_polars_polars_tests.sh
💤 Files with no reviewable changes (1)
  • ci/run_cudf_polars_polars_tests.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded the Polars test suite to include shuffle and group-by reseeding scenarios, improving coverage and confidence in related behavior.

Walkthrough

The Polars test runner no longer deselects test_shuffle_group_by_reseed, so the test is included in the test suite.

Changes

Polars test selection

Layer / File(s) Summary
Enable reseeding test
ci/run_cudf_polars_polars_tests.sh
Removed the deselection entry for test_shuffle_group_by_reseed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bc4d9

This change re-enables an existing reseeding test without altering production behavior, so no merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing the skip for test_shuffle_group_by_reseed.
Description check ✅ Passed The description explains why the skip was removed and states that the test will verify whether recent changes fixed the issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant