Use if in _CCCL_TRY_CUDA_API#9985
Open
Jacobfaib wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CUDA API wrapper replaces switch-based status handling with an explicit ChangesCUDA API error handling
Comment |
fbusato
approved these changes
Jul 16, 2026
fbusato
left a comment
Contributor
There was a problem hiding this comment.
looks good. Probably the initial intention was to handle more cases
Jacobfaib
enabled auto-merge (squash)
July 16, 2026 21:37
pciolkosz
approved these changes
Jul 17, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Jul 17, 2026
Contributor
😬 CI Workflow Results🟥 Finished in 16h 22m: Pass: 99%/120 | Total: 3d 18h | Max: 2h 26m | Hits: 55%/689556See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a simple
ifin_CCCL_TRY_CUDA_APIinstead of theswitchabomination.Also get rid of unused include,
terminate()is called by the throw macros but they already include the header for us.Checklist