[cuda.compute]: Add pytest-run-parallel#9886
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesCUDA compute parallel testing
Assessment against linked issues
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
ci/test_cuda_compute_minimal_python.sh (1)
33-33: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winsuggestion: Install pytest-run-parallel only for the 3.14t path. Line 33 adds the plugin to every Python environment, although only the later
3.14tbranch uses it. Move this install into that branch to avoid changing pytest’s plugin set for unrelated compute jobs.As per path instructions, CI reviews should focus on targeted build/test behavior and avoiding unnecessary expensive jobs.
Source: Path instructions
python/cuda_cccl/tests/compute/conftest.py (1)
139-144: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winsuggestion: Distinguish
autofrom confirmed parallel execution.running_parallelbecomes true for--parallel-threads=auto, even when the plugin falls back to one thread. That disablesraise_on_numba_importduring a serial run. Use the plugin’s effective thread count if available, or restrict this bypass to the explicit numeric> 1mode used by CI. (github.com)Source: MCP tools
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7053df74-86d0-4835-a3f5-6967c84d7dcb
📒 Files selected for processing (3)
ci/test_cuda_compute_minimal_python.shpython/cuda_cccl/tests/compute/conftest.pypython/cuda_cccl/tests/compute/test_no_numba.py
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 16h 02m: Pass: 100%/515 | Total: 4d 02h | Max: 55m 57s | Hits: 100%/666593See results here. |
Description
closes #9678
Checklist