cuda::std::simd: Add shr, shl, bit_reverse#10058
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe SIMD bit header now delegates to a scalar implementation header. The implementation adds per-lane bit manipulation, shift, rotate, and bit-counting APIs with constraints. Tests cover SIMD bit operations
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 01eaa830-7e69-42c3-8435-6b23a646c7ab
📒 Files selected for processing (5)
libcudacxx/include/cuda/std/__simd/bit.hlibcudacxx/include/cuda/std/__simd/bit/scalar.hlibcudacxx/test/libcudacxx/std/numerics/simd/simd.bit/bit_reverse.pass.cpplibcudacxx/test/libcudacxx/std/numerics/simd/simd.bit/shl.pass.cpplibcudacxx/test/libcudacxx/std/numerics/simd/simd.bit/shr.pass.cpp
🥳 CI Workflow Results🟩 Finished in 2h 31m: Pass: 100%/120 | Total: 1d 10h | Max: 1h 17m | Hits: 89%/427983See results here. |
Description
Add C++29 binding to
cuda::std::simdFixes #10041