Avoid importing apex transformer automatically #1801
Open
nWEIdia wants to merge 2 commits intoNVIDIA:masterfrom
Open
Avoid importing apex transformer automatically #1801nWEIdia wants to merge 2 commits intoNVIDIA:masterfrom
nWEIdia wants to merge 2 commits intoNVIDIA:masterfrom
Conversation
…s more clear when apex.transformer is explicitly called on unsupported platform
crcrpar
reviewed
May 9, 2024
Co-authored-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
approved these changes
May 9, 2024
Collaborator
There was a problem hiding this comment.
also, remove "transformer" from the dunder all
Collaborator
Author
There was a problem hiding this comment.
Sorry, "the dunder all" means? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and make error message more clear when apex.transformer is explicitly called on unsupported platform
In some configurations, pytorch may not be built with distributed support.
So we avoid the auto import of transformer, which calls torch.distributed api explicitly.