fix(recipe): align AKS training K8s floors with DRA-GA >= 1.34 rationale#1908
Open
mohityadav8 wants to merge 1 commit into
Open
fix(recipe): align AKS training K8s floors with DRA-GA >= 1.34 rationale#1908mohityadav8 wants to merge 1 commit into
mohityadav8 wants to merge 1 commit into
Conversation
Bumps the remaining AKS training leaves (aks-training, a100/h100 base, ubuntu, and kubeflow overlays) from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml. The Slurm leaf was already correct (bumped in NVIDIA#1744). Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with sibling leaf cases so the whole AKS training family's resolved floor is pinned, not just the Slurm leaf. Syncs the resolved example recipe. Fixes: NVIDIA#1772
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughAKS training recipe overlays for the general, A100, and H100 variants now require Kubernetes server version Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the remaining AKS training leaves (aks-training, a100/h100 base, ubuntu, and kubeflow overlays) from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml. The Slurm leaf was already correct (bumped in #1744).
Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with sibling leaf cases so the whole AKS training family's resolved floor is pinned, not just the Slurm leaf. Syncs the resolved example recipe.
Fixes: #1772