Skip to content

fix(recipe): align AKS training K8s floors with DRA-GA >= 1.34 rationale#1908

Open
mohityadav8 wants to merge 1 commit into
NVIDIA:mainfrom
mohityadav8:fix/issue-1772-aks-training-k8s-floor
Open

fix(recipe): align AKS training K8s floors with DRA-GA >= 1.34 rationale#1908
mohityadav8 wants to merge 1 commit into
NVIDIA:mainfrom
mohityadav8:fix/issue-1772-aks-training-k8s-floor

Conversation

@mohityadav8

Copy link
Copy Markdown
Contributor

Bumps the remaining AKS training leaves (aks-training, a100/h100 base, ubuntu, and kubeflow overlays) from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml. The Slurm leaf was already correct (bumped in #1744).

Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with sibling leaf cases so the whole AKS training family's resolved floor is pinned, not just the Slurm leaf. Syncs the resolved example recipe.

Fixes: #1772

Bumps the remaining AKS training leaves (aks-training, a100/h100 base,
ubuntu, and kubeflow overlays) from >= 1.30 / >= 1.32.4 to >= 1.34,
matching the DRA-GA rationale already stated in aks.yaml. The Slurm
leaf was already correct (bumped in NVIDIA#1744).

Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with sibling
leaf cases so the whole AKS training family's resolved floor is
pinned, not just the Slurm leaf. Syncs the resolved example recipe.

Fixes: NVIDIA#1772
@mohityadav8
mohityadav8 requested review from a team as code owners July 24, 2026 10:17
@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f9097a44-4c24-43c5-bee0-656bddebcac7

📥 Commits

Reviewing files that changed from the base of the PR and between 5a671a9 and 79e74aa.

📒 Files selected for processing (9)
  • examples/recipes/aks-training.yaml
  • pkg/recipe/metadata_store_test.go
  • recipes/overlays/a100-aks-training.yaml
  • recipes/overlays/a100-aks-ubuntu-training-kubeflow.yaml
  • recipes/overlays/a100-aks-ubuntu-training.yaml
  • recipes/overlays/aks-training.yaml
  • recipes/overlays/h100-aks-training.yaml
  • recipes/overlays/h100-aks-ubuntu-training-kubeflow.yaml
  • recipes/overlays/h100-aks-ubuntu-training.yaml

📝 Walkthrough

Walkthrough

AKS training recipe overlays for the general, A100, and H100 variants now require Kubernetes server version >= 1.34 instead of lower floors. The metadata store regression test was expanded to cover additional AKS training combinations and verify that the resolved floor remains >= 1.34.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mchmarny

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: raising AKS training K8s floors to 1.34.
Description check ✅ Passed The description matches the implemented changes and mentions the floor bumps, test expansion, and synced example recipe.
Linked Issues check ✅ Passed The PR updates the remaining AKS training leaves to 1.34 and extends the regression test as requested in #1772.
Out of Scope Changes check ✅ Passed The shown changes stay focused on AKS training version floors, test coverage, and a synced recipe example.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align AKS training K8s floors with DRA-GA >= 1.34 rationale

1 participant