[None][chore] Remove closed bugs by xinhe-nv · Pull Request #13189 · NVIDIA/TensorRT-LLM

xinhe-nv · 2026-04-19T12:18:40Z

Remove closed bugs from waives.txt

Summary by CodeRabbit

Tests
- Expanded test validation coverage by removing previously skipped test cases, ensuring more comprehensive testing of core components.

xinhe-nv · 2026-04-20T02:11:45Z

/bot run

coderabbitai · 2026-04-20T02:12:37Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e289fdc0-3826-4661-be38-bee761f3989c

📥 Commits

Reviewing files that changed from the base of the PR and between a56a8d2 and 7043374.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Removed 18 SKIP waiver entries from the test waives configuration file, un-skipping various test cases across MOE, flashinfer, E2E, and accuracy test modules.

Changes

Cohort / File(s)	Summary
Test Waivers `tests/integration/test_lists/waives.txt`	Removed 18 SKIP entries for test cases including MOE FP4 tests, flashinfer fused MOE tests, E2E guided decoding tests, and accuracy tests for multiple model variants (GPTOSS, Llama3.1 8B Instruct, Gemma 3.1B Instruct).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

[None][chore] Remove closed bugs #11527: Both PRs modify waives.txt by removing/updating SKIP entries for specific tests.
[None][chore] Remove closed bugs #12766: Both PRs modify waives.txt to remove SKIP waiver entries for specific test cases.
[None][chore] Remove closed bugs #12222: Both PRs modify waives.txt to remove or rework SKIP entries for integration/accuracy tests.

Suggested reviewers

crazydemo
jieli-matrix
LarryXFly

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description is minimal and lacks required template sections like detailed explanation, test coverage information, and PR checklist confirmation.	Expand the description to include a clear explanation of why these specific bugs are being removed and confirm relevant test coverage or impact assessment.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the changeset: it removes closed bugs from waives.txt, which aligns with dropping 18 SKIP entries from the waives list.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-04-20T02:18:46Z

PR_Github #44249 [ run ] triggered by Bot. Commit: 7043374 Link to invocation

tensorrt-cicd · 2026-04-20T02:27:34Z

PR_Github #44249 [ run ] completed with state FAILURE. Commit: 7043374
/LLM/main/L0_MergeRequest_PR pipeline #34670 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-20T02:38:29Z

/bot run

tensorrt-cicd · 2026-04-20T02:43:58Z

PR_Github #44261 [ run ] triggered by Bot. Commit: 531aec2 Link to invocation

tensorrt-cicd · 2026-04-20T03:29:36Z

PR_Github #44261 [ run ] completed with state FAILURE. Commit: 531aec2
/LLM/main/L0_MergeRequest_PR pipeline #34682 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-20T05:23:37Z

/bot run

tensorrt-cicd · 2026-04-20T05:29:05Z

PR_Github #44313 [ run ] triggered by Bot. Commit: 7527a12 Link to invocation

tensorrt-cicd · 2026-04-20T05:40:22Z

PR_Github #44313 [ run ] completed with state FAILURE. Commit: 7527a12
/LLM/main/L0_MergeRequest_PR pipeline #34734 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-20T07:36:23Z

/bot run

tensorrt-cicd · 2026-04-20T07:42:12Z

PR_Github #44384 [ run ] triggered by Bot. Commit: 30133a8 Link to invocation

tensorrt-cicd · 2026-04-20T08:13:08Z

PR_Github #44384 [ run ] completed with state FAILURE. Commit: 30133a8
/LLM/main/L0_MergeRequest_PR pipeline #34799 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-20T08:15:34Z

/bot run

tensorrt-cicd · 2026-04-20T08:22:26Z

PR_Github #44400 [ run ] triggered by Bot. Commit: 30133a8 Link to invocation

tensorrt-cicd · 2026-04-20T12:06:09Z

PR_Github #44400 [ run ] completed with state SUCCESS. Commit: 30133a8
/LLM/main/L0_MergeRequest_PR pipeline #34815 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-21T02:04:28Z

/bot run

tensorrt-cicd · 2026-04-21T02:11:25Z

PR_Github #44567 [ run ] triggered by Bot. Commit: 4bbfcbf Link to invocation

tensorrt-cicd · 2026-04-21T04:37:23Z

PR_Github #44567 [ run ] completed with state SUCCESS. Commit: 4bbfcbf
/LLM/main/L0_MergeRequest_PR pipeline #34955 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>

xinhe-nv · 2026-04-21T06:23:50Z

/bot run

tensorrt-cicd · 2026-04-21T06:32:03Z

PR_Github #44652 [ run ] triggered by Bot. Commit: 28a5458 Link to invocation

tensorrt-cicd · 2026-04-21T08:40:22Z

PR_Github #44652 [ run ] completed with state SUCCESS. Commit: 28a5458
/LLM/main/L0_MergeRequest_PR pipeline #35027 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>

xinhe-nv · 2026-04-21T08:43:56Z

/bot run

tensorrt-cicd · 2026-04-21T08:49:42Z

PR_Github #44682 [ run ] triggered by Bot. Commit: 67bbd9b Link to invocation

tensorrt-cicd · 2026-04-21T17:07:00Z

PR_Github #44682 [ run ] completed with state SUCCESS. Commit: 67bbd9b
/LLM/main/L0_MergeRequest_PR pipeline #35049 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-22T01:52:49Z

/bot run

tensorrt-cicd · 2026-04-22T01:58:40Z

PR_Github #44847 [ run ] triggered by Bot. Commit: 67bbd9b Link to invocation

tensorrt-cicd · 2026-04-22T03:41:58Z

PR_Github #44847 [ run ] completed with state SUCCESS. Commit: 67bbd9b
/LLM/main/L0_MergeRequest_PR pipeline #35188 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

xinhe-nv · 2026-04-22T07:46:03Z

/bot run

tensorrt-cicd · 2026-04-22T07:51:36Z

PR_Github #44933 [ run ] triggered by Bot. Commit: 67bbd9b Link to invocation

xinhe-nv requested review from LarryXFly and crazydemo April 19, 2026 12:18

github-actions Bot assigned xinhe-nv Apr 19, 2026

xinhe-nv requested a review from jieli-matrix April 20, 2026 02:00

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch from 8dd9a9d to 7043374 Compare April 20, 2026 02:00

xinhe-nv marked this pull request as ready for review April 20, 2026 02:11

xinhe-nv enabled auto-merge (squash) April 20, 2026 02:11

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch from 7043374 to 531aec2 Compare April 20, 2026 02:38

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch 2 times, most recently from ad36f83 to 7527a12 Compare April 20, 2026 05:23

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch from 30133a8 to fa3009c Compare April 20, 2026 08:55

jieli-matrix approved these changes Apr 20, 2026

View reviewed changes

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch 2 times, most recently from 887cab8 to 8e599b8 Compare April 20, 2026 10:07

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch from 04e7723 to 4bbfcbf Compare April 21, 2026 01:56

update waive list

28a5458

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>

xinhe-nv force-pushed the user/qa/unwaive_20260419 branch from 4bbfcbf to 28a5458 Compare April 21, 2026 06:23

xinhe-nv added 2 commits April 21, 2026 16:43

Merge branch 'main' into user/qa/unwaive_20260419

d327095

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>

Update waives.txt

67bbd9b

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com>

Conversation

xinhe-nv commented Apr 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

xinhe-nv commented Apr 20, 2026

Uh oh!

coderabbitai Bot commented Apr 20, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 inconclusive)

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

xinhe-nv commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

xinhe-nv commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

xinhe-nv commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

xinhe-nv commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

tensorrt-cicd commented Apr 20, 2026

Uh oh!

xinhe-nv commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

xinhe-nv commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

xinhe-nv commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

tensorrt-cicd commented Apr 21, 2026

Uh oh!

xinhe-nv commented Apr 22, 2026

Uh oh!

tensorrt-cicd commented Apr 22, 2026

Uh oh!

tensorrt-cicd commented Apr 22, 2026

Uh oh!

xinhe-nv commented Apr 22, 2026

Uh oh!

tensorrt-cicd commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xinhe-nv commented Apr 19, 2026 •

edited by coderabbitai Bot

Loading