Skip to content

[https://nvbugs/6076564][fix] unwaive TestNemotronH::test_auto_dtype[trtllm-flashinfer_ssm-False]#13187

Open
tcherckez-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
tcherckez-nvidia:unwaive-6076564
Open

[https://nvbugs/6076564][fix] unwaive TestNemotronH::test_auto_dtype[trtllm-flashinfer_ssm-False]#13187
tcherckez-nvidia wants to merge 1 commit intoNVIDIA:mainfrom
tcherckez-nvidia:unwaive-6076564

Conversation

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator

@tcherckez-nvidia tcherckez-nvidia commented Apr 19, 2026

Summary by CodeRabbit

Release Notes

  • Tests
    • Enabled previously waived test case to ensure code quality validation is fully active.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…trtllm-flashinfer_ssm-False]

Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9dcace1a-c473-4916-98ca-19f44c52ea78

📥 Commits

Reviewing files that changed from the base of the PR and between fc9d130 and 8129dc9.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A waiver entry for a test case in the accuracy testing module was removed from the skip list, allowing the test to run instead of being skipped.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Removed waiver entry for accuracy/test_llm_api_autodeploy.py::TestNemotronH::test_auto_dtype[trtllm-flashinfer_ssm-False] (reference: https://nvbugs/6076564).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description uses the repository template but all substantive sections (Description and Test Coverage) are empty, providing no explanation of the issue or test coverage details. Add details under Description explaining why the test is being unwaived and under Test Coverage explaining which tests validate this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly identifies the specific test case being unwaived and references the NVBugs ticket, following the repository's required format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tcherckez-nvidia
Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "H100_PCIe-AutoDeploy-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44180 [ run ] triggered by Bot. Commit: 8129dc9 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #44180 [ run ] completed with state SUCCESS. Commit: 8129dc9
/LLM/main/L0_MergeRequest_PR pipeline #34607 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants