[None][chore] Add Dynamo configs to TRTLLM CI - Disagg - Part 2#13168
[None][chore] Add Dynamo configs to TRTLLM CI - Disagg - Part 2#13168brb-nv wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
📝 WalkthroughWalkthroughThis pull request adds support for H200 8-GPU performance sanity testing by introducing a new Groovy stage configuration, model path mappings for two FP8 models, a test-list definition, and three disaggregated performance sanity benchmark configurations with varying model and parameter combinations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/perf/test_perf_sanity.py`:
- Around line 52-54: The SPDX copyright header year at the top of the modified
file needs to be updated to 2026; locate the file by spotting the dictionary
entries like "super_fp8", "qwen3_235b_a22b_fp8", or "qwen3_32b_fp8" and change
the SPDX header line (currently ending in 2025) to end in 2026 so the file
reflects the latest modification year. Ensure the header format matches existing
project headers exactly (SPDX and any NVIDIA notice) and save the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 42d06aa9-d436-4ed6-a627-847d3e7a757a
📒 Files selected for processing (6)
jenkins/L0_Test.groovytests/integration/defs/perf/test_perf_sanity.pytests/integration/test_lists/test-db/l0_dgx_h200_perf_sanity.ymltests/scripts/perf-sanity/disaggregated/h200_nemotron-super-fp8_8k1k_con64_ctx1_tp2_gen1_tp2_eplb0_mtp0_ccb-UCX.yamltests/scripts/perf-sanity/disaggregated/h200_qwen3-235b-a22b-fp8_8k1k_con512_ctx1_tp2_gen1_tep4_eplb0_mtp0_ccb-DEFAULT.yamltests/scripts/perf-sanity/disaggregated/h200_qwen3-32b-fp8_4k1k_con128_ctx1_tp1_gen1_tp2_eplb0_mtp0_ccb-DEFAULT.yaml
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
f259d72 to
774b1aa
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #44079 [ run ] triggered by Bot. Commit: |
|
PR_Github #44079 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
|
bot run --stage-list "DGX_H200-8_GPUs-PyTorch-PerfSanity-Post-Merge-1" |
Description
This MR adds Dynamo configs to TRTLLM CI to catch issues early. This MR has disagg configs for gb200.
Test Coverage
N/A
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit