[None][chore] Update flashinfer-python from 0.6.6 to 0.6.8rc1#13064
[None][chore] Update flashinfer-python from 0.6.6 to 0.6.8rc1#13064yihwang-nv wants to merge 21 commits intoNVIDIA:mainfrom
Conversation
Bump flashinfer-python dependency to 0.6.8rc1. Also update nvidia-cutlass-dsl from 4.3.4 to 4.4.2 (required by flashinfer >=4.4.2). Updated version pins in requirements.txt, security_scanning/pyproject.toml, security_scanning/poetry.lock, and ATTRIBUTIONS-Python.md. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --stage-list "Build-Docker-Images" |
📝 WalkthroughWalkthroughThis change updates two CUDA-related package dependencies across three configuration files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@requirements.txt`:
- Line 57: requirements.txt currently pins flashinfer-python==0.6.8rc1 which is
not on PyPI; either revert the pin to a published version (e.g., 0.6.7.post3) or
add the FlashInfer nightly wheel index to your install config (e.g., add
--extra-index-url https://flashinfer.ai/whl/nightly/ in CI and developer docs)
and update CI/pip config accordingly; also run compatibility tests and review
tensorrt_llm/_torch/attention_backend/flashinfer.py plus any callers for API
changes between 0.6.6/0.6.7 and the nightly to ensure no breaking changes before
keeping 0.6.8rc1.
In `@security_scanning/pyproject.toml`:
- Line 58: Replace the non-existent dependency "flashinfer-python (==0.6.8rc1)"
in pyproject.toml with an available release (e.g., "flashinfer-python
(==0.6.7.post3)"), then regenerate any lockfiles (poetry lock / pip-compile) and
verify installation to ensure the package resolves correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8c184ec0-702c-44f0-a56a-0484b3a8d283
⛔ Files ignored due to path filters (1)
security_scanning/poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
ATTRIBUTIONS-Python.mdrequirements.txtsecurity_scanning/pyproject.toml
|
PR_Github #43382 [ run ] triggered by Bot. Commit: |
Force-reinstall nvidia-cutlass-dsl and nvidia-cutlass-dsl-libs-base in the Docker build to replace the stale 4.3.5 from the base image with 4.4.2. Add nvidia-cutlass-dsl>=4.4.2 to constraints.txt. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --stage-list "Build-Docker-Images" |
Force-reinstall nvidia-cutlass-dsl and nvidia-cutlass-dsl-libs-base in the Docker build to replace the stale 4.3.5 from the base image with 4.4.2. Add nvidia-cutlass-dsl>=4.4.2 to constraints.txt. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #43382 [ run ] completed with state |
|
PR_Github #43386 [ run ] triggered by Bot. Commit: |
Point current_image_tags.properties to the CI tritondevel images built from PR NVIDIA#13064 (flashinfer + nvidia-cutlass-dsl upgrade). Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #43410 [ run ] triggered by Bot. Commit: |
The DLFW base image (pytorch:26.02-py3) ships nvidia-cutlass-dsl 4.3.5. When pip upgrades to 4.4.2 in-place, it corrupts shared namespace dirs. Add explicit uninstall + rm -rf cleanup before tensorrt_llm wheel install. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run |
|
PR_Github #43459 [ run ] triggered by Bot. Commit: |
This reverts commit 0dd321a59fc067e5fd3124f1fb5c6b8aba1d7ad3.
pip installs dependency packages (nvidia-cutlass-dsl-libs-base) before uninstalling the old meta-wheel (nvidia-cutlass-dsl). Since both write to the same nvidia_cutlass_dsl/ directory, the uninstall step removes files that the deps just installed, breaking the package. Add scripts/clean_site_packages.py that uninstalls known problematic packages and removes leftover site-packages fragments before install. Call it from test_pip_install.py before both wheel and editable installs. This avoids Docker image changes — the cleanup runs at CI test time. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #43474 [ run ] triggered by Bot. Commit: |
|
PR_Github #43459 [ run ] completed with state |
|
PR_Github #43474 [ run ] completed with state
|
…lass-dsl 4.4.2 PipelineAsync.producer_tail is decorated with @dsl_user_op in cutlass-dsl 4.4.2 and forwards loc/ip kwargs to producer_acquire. The overrides in custom_pipeline.py did not accept these, raising DSLRuntimeError in test_fp4_linear_cute_dsl. Add loc=None, ip=None keyword-only parameters to producer_acquire, producer_commit, consumer_release, and producer_tail across PipelineTmaUmma, PipelineUmmaAsync, and PipelineCpAsyncUmma, and thread them through to the inner sync_object and cute.arch calls. Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #44129 [ run ] triggered by Bot. Commit: |
|
PR_Github #44129 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44179 [ run ] triggered by Bot. Commit: |
|
PR_Github #44179 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44259 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #44259 [ run ] completed with state
|
|
PR_Github #44264 [ run ] triggered by Bot. Commit: |
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #44302 [ run ] triggered by Bot. Commit: |
|
PR_Github #44302 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44335 [ run ] triggered by Bot. Commit: |
|
PR_Github #44335 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #44367 [ run ] triggered by Bot. Commit: |
|
PR_Github #44367 [ run ] completed with state
|
Point current_image_tags.properties to the CI tritondevel images built from PR NVIDIA#13064 (flashinfer + nvidia-cutlass-dsl upgrade). Signed-off-by: Yihan Wang <yihwang@nvidia.com>
|
/bot run --disable-fail-fast |
|
PR_Github #44387 [ run ] triggered by Bot. Commit: |
|
PR_Github #44387 [ run ] completed with state
|
Summary
>=4.4.2)Test plan
pip install -r requirements.txtinstalls successfullypytest tests/unittest/_torch/flashinfer/ -vpytest tests/unittest/_torch/attention/test_flashinfer_attention.py -vSummary by CodeRabbit
Chores