Improve build-te for build-jax step in CI #2245
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
| # Never trace this script: it handles credentials mounted by BuildKit. | ||
| set +x | ||
|
|
||
| compiler_cache_args=() | ||
| case "${ENABLE_NVTE_SCCACHE:-0}" in | ||
| 1) | ||
| required_sccache_secrets=( | ||
| AWS_ACCESS_KEY_ID | ||
| AWS_SECRET_ACCESS_KEY | ||
| AWS_SESSION_TOKEN | ||
| SCCACHE_BUCKET | ||
| ) | ||
| for secret_name in "${required_sccache_secrets[@]}"; do | ||
| if [[ ! -s "/run/secrets/${secret_name}" ]]; then | ||
| echo "ENABLE_NVTE_SCCACHE=1 requires the ${secret_name} BuildKit secret" >&2 | ||
| exit 1 | ||
| fi | ||
| done | ||
|
|
||
| for secret_name in "${required_sccache_secrets[@]}"; do | ||
| printf -v "${secret_name}" '%s' "$(<"/run/secrets/${secret_name}")" | ||
| export "${secret_name}" | ||
| done | ||
|
|
||
| : "${SCCACHE_REGION:?ENABLE_NVTE_SCCACHE=1 requires SCCACHE_REGION}" | ||
| : "${TARGETARCH:?BuildKit did not provide TARGETARCH}" | ||
| export NVTE_CCACHE_BIN=sccache | ||
| export SCCACHE_REGION | ||
| export SCCACHE_S3_KEY_PREFIX="sccache/${TARGETARCH}" | ||
| export SCCACHE_S3_USE_SSL=true | ||
| compiler_cache_args+=(--ccache) | ||
| ;; | ||
| 0) | ||
| ;; | ||
| *) | ||
| echo "ENABLE_NVTE_SCCACHE must be 0 or 1" >&2 | ||
| exit 1 | ||
| ;; | ||
| esac | ||
|
|
||
| exec build-te.sh "${compiler_cache_args[@]}" "$@" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| #!/bin/bash | ||
|
Contributor
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment. 0.17.0 is released, can this all be dropped?
Contributor
Author
There was a problem hiding this comment. Not yet, I tried to get this script in a better shape though. |
||
| set -euo pipefail | ||
|
|
||
| usage() { | ||
| echo "Install a compiler cache used by build-te.sh" | ||
| echo "" | ||
| echo " Usage: $0 [ccache|sccache]" | ||
| echo "" | ||
| echo " If no argument is provided, NVTE_CCACHE_BIN selects the cache." | ||
| exit "${1}" | ||
| } | ||
|
|
||
| if [[ "$#" -gt 1 ]]; then | ||
| usage 1 | ||
| fi | ||
| if [[ "${1:-}" == "-h" || "${1:-}" == "--help" ]]; then | ||
| usage 0 | ||
| fi | ||
|
|
||
| CACHE_BINARY="${1:-${NVTE_CCACHE_BIN:-ccache}}" | ||
| case "${CACHE_BINARY}" in | ||
| ccache) | ||
| if command -v ccache &> /dev/null; then | ||
| echo "Compiler cache already installed: $(command -v ccache)" | ||
| exit 0 | ||
| fi | ||
| export DEBIAN_FRONTEND=noninteractive | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends ccache | ||
| rm -rf /var/lib/apt/lists/* | ||
| ;; | ||
| sccache) | ||
| readonly SCCACHE_SOURCE_URL="https://github.com/mozilla/sccache.git" | ||
| readonly SCCACHE_SOURCE_COMMIT="e9b15a35f7240a7edd1b9644583edb388c6cb5f9" | ||
| readonly SCCACHE_RUST_TOOLCHAIN="1.88.0" | ||
| readonly SCCACHE_RUSTUP_VERSION="1.29.0" | ||
|
|
||
| case "$(dpkg --print-architecture)" in | ||
| amd64) | ||
| SCCACHE_RUSTUP_HOST="x86_64-unknown-linux-gnu" | ||
| ;; | ||
| arm64) | ||
| SCCACHE_RUSTUP_HOST="aarch64-unknown-linux-gnu" | ||
| ;; | ||
| *) | ||
| echo "Unsupported architecture for sccache: $(dpkg --print-architecture)" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
|
|
||
| SCCACHE_TMPDIR="$(mktemp -d)" | ||
| cleanup() { | ||
| rm -rf -- "${SCCACHE_TMPDIR}" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| export DEBIAN_FRONTEND=noninteractive | ||
| apt-get update | ||
| apt-get install -y --no-install-recommends libssl-dev pkg-config | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| export CARGO_HOME="${SCCACHE_TMPDIR}/cargo" | ||
| export RUSTUP_HOME="${SCCACHE_TMPDIR}/rustup" | ||
| SCCACHE_RUSTUP_INIT="${SCCACHE_TMPDIR}/rustup-init" | ||
| SCCACHE_RUSTUP_URL="https://static.rust-lang.org/rustup/archive/${SCCACHE_RUSTUP_VERSION}/${SCCACHE_RUSTUP_HOST}/rustup-init" | ||
|
|
||
| wget -nv --tries=5 --retry-connrefused \ | ||
| -O "${SCCACHE_RUSTUP_INIT}" "${SCCACHE_RUSTUP_URL}" | ||
| wget -nv --tries=5 --retry-connrefused \ | ||
| -O- "${SCCACHE_RUSTUP_URL}.sha256" \ | ||
| | awk -v binary="${SCCACHE_RUSTUP_INIT}" '{print $1" "binary}' \ | ||
| | sha256sum -c - | ||
| chmod 755 "${SCCACHE_RUSTUP_INIT}" | ||
| "${SCCACHE_RUSTUP_INIT}" \ | ||
| -y \ | ||
| --no-modify-path \ | ||
| --profile minimal \ | ||
| --default-toolchain "${SCCACHE_RUST_TOOLCHAIN}" | ||
|
|
||
| "${CARGO_HOME}/bin/cargo" install sccache \ | ||
| --git "${SCCACHE_SOURCE_URL}" \ | ||
| --rev "${SCCACHE_SOURCE_COMMIT}" \ | ||
| --locked \ | ||
| --no-default-features \ | ||
| --features=s3 \ | ||
| --bin sccache \ | ||
| --root /usr/local \ | ||
| --no-track \ | ||
| --force | ||
| ;; | ||
| *) | ||
| echo "${CACHE_BINARY} is not installed; automatic installation supports only ccache and sccache" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
|
|
||
| if ! command -v "${CACHE_BINARY}" &> /dev/null; then | ||
| echo "Compiler cache installation did not provide ${CACHE_BINARY}" | ||
| exit 1 | ||
| fi | ||
| echo "Installed compiler cache: $(command -v "${CACHE_BINARY}")" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-te-with-sccache.shis a thin BuildKit-specific wrapper aroundbuild-te.sh. It keeps Docker secret handling separate from the normalTransformer Engine build logic.
When
ENABLE_NVTE_SCCACHE=1, the wrapper:process tree.
--ccacheto thebuild-te.shinvocation.