Speed up ConMon data extraction - #221
Merged
EdwardSafford-NOAA merged 3 commits intoJul 10, 2026
Merged
EdwardSafford-NOAA merged 3 commits into
EdwardSafford-NOAA merged 3 commits into
Conversation
Make time_vert and horz_hist scripts run as background subprocesses.
Reduce wall time.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Conventional Monitor (ConMon) data extraction wall time by parallelizing the time_vert.sh and horz_hist.sh extraction steps, aligning with Issue #220’s goal of reducing end-to-end runtime.
Changes:
- Run
time_vert.shandhorz_hist.shconcurrently in separate working directories to avoid scratch-file collisions. - Add per-script log capture for the parallel extraction runs.
- Reduce batch scheduler walltime requests for the data extraction job (notably on ursa and wcoss2).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Conventional_Monitor/nwprod/gdas_conmon/scripts/exgdas_atmos_conmon.sh | Runs time/vertical and horizontal-history extraction scripts in parallel using dedicated work dirs and log files. |
| src/Conventional_Monitor/data_extract/ush/ConMon_DE.sh | Updates scheduler submission walltime values for ursa and wcoss2 data extraction jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add quoted paths and modify scripts to resist failures if variables are undefined.
RussTreadon-NOAA
approved these changes
Jul 10, 2026
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @EdwardSafford-NOAA . Reducing wall time from an hour to 15 minutes is significant. Thank you for running tests to confirm that the revised scripts yield results identical with the current (slower) scripts.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of ConMon's data extraction by running the
time_vert.shandhorz_hist.shscripts as child sub-processes in dedicated spaces. Heretofore the two scripts were run serially. This change has significantly improved wall time performance reducing run times from an hour and change to ~15 min. on both ursa and wcoss2.Testing has been done on wcoss2 using operational gfs data over the last 4 cycles. Output is as expected and wall times are significantly improved.
Closes #220