Remove autoscaling configuration from PostgreSQL chart - #14
Merged
Conversation
Co-authored-by: dingp <9438483+dingp@users.noreply.github.com>
dingp
marked this pull request as ready for review
January 17, 2026 23:41
Copilot
AI
changed the title
[WIP] Update PostgreSQL Helm chart implementation based on feedback
Remove autoscaling configuration from PostgreSQL chart
Jan 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes autoscaling functionality from the PostgreSQL Helm chart based on feedback. Autoscaling is not appropriate for stateful database deployments like PostgreSQL, which require careful manual scaling to maintain data integrity and consistency.
Changes:
- Removed autoscaling configuration section from values template
- Deleted HorizontalPodAutoscaler template file
- Made replica count unconditional in deployment template
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| postgresql/values_template.yaml | Removed autoscaling configuration block (lines 151-158) to simplify values |
| postgresql/templates/hpa.yaml | Deleted entire HPA template file as autoscaling is not suitable for PostgreSQL |
| postgresql/templates/deployment.yaml | Removed conditional logic around replicas field, making it always use the configured replicaCount |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizontal pod autoscaling is incompatible with stateful databases like PostgreSQL. The previous implementation included autoscaling configuration that, while disabled by default, could be mistakenly enabled.
Changes
autoscalingsection fromvalues_template.yamltemplates/hpa.yamlHorizontalPodAutoscaler templatetemplates/deployment.yamlto always setreplicasfromreplicaCountThe chart now has no autoscaling capability, preventing misconfiguration of the stateful PostgreSQL deployment.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.