Skip to content

Fix typos and translate English terms to French - #344

Merged
NaysKutzu merged 1 commit into
MythicalLTD:v3-remasteredfrom
achul123:patch-1
Nov 8, 2025
Merged

NaysKutzu merged 1 commit into
MythicalLTD:v3-remasteredfrom
achul123:patch-1

Conversation

@achul123

@achul123 achul123 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

I know I must have forgotten a lot of mistakes but I'm too lazy to recheck 1500 lines.

@achul123
achul123 requested a review from NaysKutzu as a code owner November 7, 2025 22:26
@coderabbitai

coderabbitai Bot commented Nov 7, 2025 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Improved French language translations with corrected grammar, spelling, accents, and punctuation
    • Standardized French terminology, capitalization, and formatting consistency across UI elements
    • Enhanced clarity of user-facing French strings and messages

Walkthrough

This pull request corrects and standardizes French localization strings in the frontend UI, addressing typos, accents, capitalization, grammar, and punctuation. No structural changes to the file or API modifications are made.

Changes

Cohort / File(s) Summary
French localization corrections
frontend/src/locale/fr.yml
Fixed typos, accents, and capitalization across UI strings (e.g., "Retour à l' acueil" → "Retour à l'accueil"); standardized apostrophes and French grammar; shortened success messages; replaced English phrases with French translations; corrected punctuation and typographic details throughout auth, account, store, referrals, and profile sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Single-file localization update with repetitive, homogeneous corrections (typos and formatting)
  • No logic or structural changes to validate
  • Primary focus: spot-checking sample corrections and verifying French grammar accuracy

Possibly related PRs

  • MythicalDash#276: Directly related, as it also modifies the French localization file (frontend/src/locale/fr.yml), likely adding the file or providing baseline translations that this PR now corrects.

Suggested reviewers

  • NaysKutzu

Poem

🐰 Hopping through the accents so fine,
Fixing apostrophes, line by line,
From "acueil" to "accueil," the French shines bright,
Grammar polished, typography right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: fixing typos and translating English terms to French in the French locale file.
Description check ✅ Passed The description is related to the changeset as it acknowledges incomplete review of the 1500-line French translation file being modified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae69083 and 9e580ed.

📒 Files selected for processing (1)
  • frontend/src/locale/fr.yml (21 hunks)
🔇 Additional comments (13)
frontend/src/locale/fr.yml (13)

18-18: Correct French elision and accent.

The apostrophe correction from "l' acueil" to "l'accueil" properly follows French grammatical rules. Approved.


199-199: Correct French verb conjugation.

Fixed "S'inscire" → "S'inscrire" (proper infinitive form). Approved.


208-208: Technical term appropriately preserved.

CSRF acronym is correctly retained while surrounding text is properly French. Approved.


675-675: Correct French translation.

"Aperçu de l'image" is proper French. Approved.


747-747: Appropriate error message translation.

Technical term "Cluster" appropriately preserved while message is translated to French. Approved.


764-764: Consistent API translation.

"Clé API" maintains translation consistency with earlier section (lines 610–620). Approved.


797-797: Consistent and appropriate French translations.

Both corrections are consistent with earlier translations and use proper French conventions (elision, greeting punctuation). Approved.

Also applies to: 802-802


841-841: Consistent table messaging.

"Aucune donnée trouvée" is proper French and consistent with similar messages elsewhere in the file. Approved.


916-916: Proper French dashboard button translations.

Both "Retour au tableau de bord" translations are correct French and appropriately repeated across different sections. Approved.

Also applies to: 955-955


1053-1053: Contextually appropriate resource terminology.

"Emplacements" and "Disponibilité des ressources" are proper French translations for server resource context. Approved.

Also applies to: 1055-1056


1195-1195: Store section translations are appropriate.

Changes to "Êtes vous sûre" (feminine form), "Coins insuffisants" (plural), "Dépenser des coins" (verb form), and "Emplacement de Serveur" (French for server slot) all appear grammatically correct. Approved.

Also applies to: 1233-1233, 1244-1244, 1290-1290


1326-1326: Profile and resource section translations are appropriate.

Translations of "compléter l'offre" (complete the offer), "Dernière vue" (last seen), activity labels, and "Limites des ressources" (resource limits) are all grammatically correct. Approved.

Also applies to: 1464-1465, 1471-1471, 1474-1475


1-1500: Overall assessment: Solid French localization fixes with minor spelling oversights.

The PR successfully addresses numerous typos, accents, and English-to-French translations throughout the file. The bulk of changes are appropriate and grammatically correct. However, I've identified a few minor spelling issues (missing accents on "Mémoire" and "supplémentaire") and one untranslated English term ("API Documentation") that should be addressed before merge. The file maintains proper YAML structure and French conventions overall.

Please address the flagged spelling corrections and untranslated term noted in prior comments before merging.

header:
uuid: 'UUID:'
ip: 'Addresse IP!'
ip: 'Adresse IP!'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

Inconsistent punctuation in label.

The exclamation mark breaks the pattern used elsewhere in the header section (e.g., "UUID:", "Première:", "Actuel:"). Consider using a colon to maintain consistency: ip: 'Adresse IP:'.


🏁 Script executed:

#!/bin/bash
# View the file context around line 384 to verify punctuation consistency
sed -n '375,395p' frontend/src/locale/fr.yml | cat -n

Length of output: 773


Inconsistent punctuation in field header label.

The exclamation mark in ip: 'Adresse IP!' breaks the pattern used by adjacent field headers (uuid: 'UUID:', first: 'Première:', current: 'Actuel:'). Consider changing to ip: 'Adresse IP:' for consistency.

🤖 Prompt for AI Agents
In frontend/src/locale/fr.yml around line 384, the label "ip: 'Adresse IP!'"
uses an exclamation mark that is inconsistent with neighboring field header
punctuation; change it to use a colon instead (ip: 'Adresse IP:') so it matches
the pattern used for other headers like "uuid: 'UUID:'" and "first:
'Première:'".

title: Emails
subTitle: Voyez vos emails!
description: "Ceci est une liste d'email. You can view the details of each email by clicking the view button."
description: "Ceci est une liste d'email. Vous pouvez consulter les détails de chaque e-mail en cliquant sur le bouton Voir."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Standardize email terminology.

The string mixes "email" (line 509, first usage) and "e-mail" (second usage). French localization should consistently use either "e-mail" or "courriel". Recommend:

-description: "Ceci est une liste d'email. Vous pouvez consulter les détails de chaque e-mail en cliquant sur le bouton Voir."
+description: "Ceci est une liste d'e-mails. Vous pouvez consulter les détails de chaque e-mail en cliquant sur le bouton Voir."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
description: "Ceci est une liste d'email. Vous pouvez consulter les détails de chaque e-mail en cliquant sur le bouton Voir."
description: "Ceci est une liste d'e-mails. Vous pouvez consulter les détails de chaque e-mail en cliquant sur le bouton Voir."
🤖 Prompt for AI Agents
In frontend/src/locale/fr.yml around line 509, the sentence mixes "email" and
"e-mail"; standardize the terminology by replacing both occurrences with a
single preferred French term (e.g., "courriel") so the description reads
consistently — update the string to use "courriel" in both places and ensure
punctuation/spacing remains correct.

info: Cette clé donne un accès complet à votre compte via l'API. Garder là en sécurité et ne la partager jamais publiquement.
resetKey: Reset API Key
resetKey: Réinitialiser la clé API
apiDocumentation: API Documentation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Translate remaining English term.

Line 620 retains English "API Documentation" while all surrounding API-related strings have been properly translated to French. Should be translated to maintain localization consistency.

-                    apiDocumentation: API Documentation
+                    apiDocumentation: Documentation de l'API
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
apiDocumentation: API Documentation
apiDocumentation: Documentation de l'API
🤖 Prompt for AI Agents
In frontend/src/locale/fr.yml around line 620 the key "apiDocumentation" is
still set to the English phrase "API Documentation"; replace its value with the
French translation (e.g., "Documentation de l’API" or "Documentation de l’API")
to match surrounding localized strings and maintain consistency in the French
locale file.

confirmButtonText: 'OK'
ram:
title: 'RAM Additionel'
title: 'RAM supplementaire'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Correct French spelling: accent on supplementary.

"Supplementaire" should be "supplémentaire" (with accent on the first 'e'). This is the correct French spelling for "supplementary/additional."

-                    title: 'RAM supplementaire'
+                    title: 'RAM supplémentaire'
-                    title: 'Stockage supplementaire'
+                    title: 'Stockage supplémentaire'

Also applies to: 1276-1276

🤖 Prompt for AI Agents
In frontend/src/locale/fr.yml around lines 1269 and 1276, the French string "RAM
supplementaire" is misspelled: replace "supplementaire" with the correctly
accented "supplémentaire" in both occurrences so the entries read "RAM
supplémentaire".

title: 'Resource Limits'
memory: 'Memory'
title: 'Limites des ressources'
memory: 'Memoire'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Correct French spelling: accent on memory.

"Memoire" should be "Mémoire" (with accent on the first 'e'). This is standard French spelling.

-        memory: 'Memoire'
+        memory: 'Mémoire'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
memory: 'Memoire'
memory: 'Mémoire'
🤖 Prompt for AI Agents
In frontend/src/locale/fr.yml around line 1472, the French translation value for
the key "memory" is misspelled as "Memoire"; change it to the correct accented
form "Mémoire" (replace the unaccented 'e' with 'é') to fix French spelling.

@NaysKutzu
NaysKutzu merged commit 2f0003b into MythicalLTD:v3-remastered Nov 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants