Open
Conversation
zhouwfang
changed the title
zhouwfang
force-pushed
the
zhoufang/iop-291-extract-mpc-into-a-separate-crate
branch
from
e63d2fc to
e40c098
Compare
zhouwfang
force-pushed
the
zhoufang/iop-291-extract-mpc-into-a-separate-crate
branch
from
e40c098 to
a680ff8
Compare
Contributor
|
Whats the main motivation for this? our code shouldn't be big enough yet to really warrant splitting this yet to get a perf bump |
Contributor
Author
Not perf, layering for code health. It makes the 3 fields in Hashi struct owned by MpcServiceState in the new crate, and Hashi delegates. So Hashi becomes a consumer of an MPC library rather than the owner of MPC internals. State changes become local to the mpc crate instead of touching Hashi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16