Skip to content

fix: preserve primary keystore errors on legacy fallback#174

Closed
Peter7896 wants to merge 1 commit into
MorpheApp:mainfrom
Peter7896:peter7896/morphe-keystore-fallback-errors
Closed

fix: preserve primary keystore errors on legacy fallback#174
Peter7896 wants to merge 1 commit into
MorpheApp:mainfrom
Peter7896:peter7896/morphe-keystore-fallback-errors

Conversation

@Peter7896
Copy link
Copy Markdown

Summary

  • extract CLI and engine legacy-keystore retry logic into a shared helper
  • preserve the original default-credential failure when the legacy retry also fails
  • add regression tests for success, retry, disabled fallback, and double-failure paths

Testing

  • git diff --check
  • ./gradlew.bat --console plain test --tests app.morphe.engine.util.KeystoreSignerTest (blocked locally: GitHub Packages dependencies returned 401 Unauthorized with the current CLI token scope)

Fixes #158

@prateek-who
Copy link
Copy Markdown
Contributor

#158 is already fixed from our side no? Pretty sure this does not do anything to close that issue. Also, this PR only extracts the logic to a common helper and adds a bunch of tests. I am sorry to ask this, but did you test anything in here? I went through your profile and it all seems like an AI commit spree. Do you have any interaction with whatever you have written here? I don't mind using AI to write stuff but I don't think you have any clue as to what it does?

blocked locally: GitHub Packages dependencies returned 401 Unauthorized with the current CLI token scope, you can literally create a PAT and this issue wouldn't happen.

@LisoUseInAIKyrios
Copy link
Copy Markdown
Contributor

This issue is already fixed on stable.

This PR and the user profile appears to be entirely AI generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: morphe key alias bug

3 participants