fix: preserve primary keystore errors on legacy fallback#174
Closed
Peter7896 wants to merge 1 commit into
Closed
Conversation
Contributor
|
#158 is already fixed from our side no? Pretty sure this does not do anything to close that issue. Also, this PR only extracts the logic to a common helper and adds a bunch of tests. I am sorry to ask this, but did you test anything in here? I went through your profile and it all seems like an AI commit spree. Do you have any interaction with whatever you have written here? I don't mind using AI to write stuff but I don't think you have any clue as to what it does?
|
Contributor
|
This issue is already fixed on stable. This PR and the user profile appears to be entirely AI generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff --check./gradlew.bat --console plain test --tests app.morphe.engine.util.KeystoreSignerTest(blocked locally: GitHub Packages dependencies returned401 Unauthorizedwith the current CLI token scope)Fixes #158