Repository navigation
Fix verifier counter leak during stale queue cleanup - #150
Merged
MoneroOcean merged 1 commit intoMay 21, 2026
Merged
Conversation
MoneroOcean
deleted the
codex/propose-fix-for-verifier-cleanup-vulnerability
branch
May 21, 2026 22:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
miner_address_verify, which could let attackers leak per-address pending counts and suppress future verifications for a victim payout address.Description
miner_address_verifywhen an expired pending task is removed during the verify queue cleanup inlib/coins/index.js, preserving the existing behavior of calling the task callback withnull.Testing
git diffforlib/coins/index.jsand committing the change successfully.Codex Task