Repository navigation
Filter BTC-style sum-vout rewards to pool address for RVN/RTM/BTRM/XNA - #145
Closed
MoneroOcean wants to merge 1 commit into
Closed
MoneroOcean wants to merge 1 commit into
MoneroOcean wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sum-voutreward accounting for some Raven-like ports was summing every coinbase output value as the block reward, which inflates the pool-creditable reward when coinbase enforces mandatory third-party outputs (masternodes/treasury/dev-fund).Description
getBtcVoutAddresses(vout)helper and updatedparseBtcRewardto accept apoolAddressargument and to respect a newrewardPoolAddressOnlyflag so thatsum-voutmode can skip outputs not paid to the configured pool address and still honorrewardIgnoreAddresswhen present (lib/coins/core/factories.js).createBtcRpcto passctx.runtime.getPoolAddress(ctx.profile)intoparseBtcRewardwhen resolving block headers so reward calculation can be pool-address aware (lib/coins/core/factories.js).rewardPoolAddressOnly: truefor the affected profilesRVN,XNA,RTM, andBTRMso those ports use pool-address-only summation (lib/coins/rvn.js,lib/coins/xna.js,lib/coins/rtm.js,lib/coins/btrm.js).tests/pool/coin/basics.js).Testing
node --checkacross the changed modules which completed successfully.node --require ./tests/common/test_output_buffer.js --test ... tests/pool/coin/basics.jsbut it failed to run due to missing test dependencies (protocol-buffersmodule not installed) and therefore the full test suite was not executed.npm installto provision test deps but it failed due to registry access returning403 Forbiddenforcrypto-js, preventing full automated test execution in this environment.Codex Task