Repository navigation
Prevent disconnected miners from bypassing invalid-share ban - #142
Merged
MoneroOcean merged 1 commit intoMay 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
miner.checkBan, allowing remote miners to disconnect after submitting invalid shares and avoid temporary bans while still consuming verification/daemon resources.Description
miner.checkBan(shareAccepted)before theminer.removed_minerearly-return inhandleShareProcessedinsidelib/pool/protocol.jsso ban/accounting runs even for shares validated after a disconnect, while preserving throttled reply behavior and existing socket reply flow.Testing
npm test --silentin this environment but the test run failed due to a missing dependency (protocol-buffers), so the full automated test suite could not be executed here.Codex Task