Skip to content

Prevent disconnected miners from bypassing invalid-share ban - #142

Merged
MoneroOcean merged 1 commit into
masterfrom
codex/propose-fix-for-invalid-share-ban-bypass
May 20, 2026
Merged

MoneroOcean merged 1 commit into
masterfrom
codex/propose-fix-for-invalid-share-ban-bypass

Conversation

@MoneroOcean

Copy link
Copy Markdown
Owner

Motivation

  • The socket-close path began marking miners as removed which caused asynchronous share-validation callbacks to return before calling miner.checkBan, allowing remote miners to disconnect after submitting invalid shares and avoid temporary bans while still consuming verification/daemon resources.

Description

  • Invoke miner.checkBan(shareAccepted) before the miner.removed_miner early-return in handleShareProcessed inside lib/pool/protocol.js so ban/accounting runs even for shares validated after a disconnect, while preserving throttled reply behavior and existing socket reply flow.

Testing

  • Ran npm test --silent in this environment but the test run failed due to a missing dependency (protocol-buffers), so the full automated test suite could not be executed here.

Codex Task

@MoneroOcean
MoneroOcean merged commit 502316b into master May 20, 2026
0 of 2 checks passed
@MoneroOcean
MoneroOcean deleted the codex/propose-fix-for-invalid-share-ban-bypass branch May 20, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant