Retry async verifier when slowHashAsync returns unknown result - #140
Merged
MoneroOcean merged 2 commits intoMay 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
false) which should trigger a retry instead of immediately failing verification.Description
verifySlowSharethat retries whenglobal.coinFuncs.slowHashAsynccalls back withfalse, using configurable limits and delays viaglobal.config.pool.verifyShareRetry.getVerifyRetryLimit()andgetVerifyRetryDelayMs()with safe defaults of3retries and30ms delay and robust parsing of the config values.nullresults and mismatched hashes while capping computed delays and retries to sane integer values.submit retries async verifier when verifier result is unknownintests/pool/validation/core.jsthat simulatesslowHashAsyncreturningfalsea few times before returning a valid result and asserts the retry behavior.Testing
tests/pool/validation/core.jsincluding the new retry test which assertsslowHashAsyncwas invoked the expected number of times and that the submission succeeded; the tests passed.nullresults and hash mismatches was exercised by the same test suite and remained unchanged.Codex Task