Skip to content

[Train] Support Fastwam training#1241

Open
Musisoul wants to merge 10 commits into
mainfrom
train-ros
Open

[Train] Support Fastwam training#1241
Musisoul wants to merge 10 commits into
mainfrom
train-ros

Conversation

@Musisoul

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the FastWAM (Mixture of Transformers) training pipeline, adding support for the LIBERO dataset, specialized preprocessing, normalization, and preparation assets. It implements the FastWAM model wrapper, ActionDiT expert, MoT architecture, and FastWAMTrainer to handle joint video and action training. The review feedback highlights several critical issues: an AttributeError in video_decoder.py caused by calling reader.container.close() on a VideoReader object; silent data corruption in processor.py due to in-place modification of a cached action tensor; potential device/dtype mismatches in normalizer.py when performing operations with CPU-bound scale and offset tensors; and a memory leak in lerobot_dataset.py caused by using @lru_cache on an instance method.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lightx2v_train/lightx2v_train/data/libero/video_decoder.py
Comment thread lightx2v_train/lightx2v_train/data/libero/processor.py
Comment thread lightx2v_train/lightx2v_train/data/libero/normalizer.py
Comment thread lightx2v_train/lightx2v_train/data/libero/lerobot_dataset.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant