Build the benchmark images from the master the chain tracks - #57
Merged
estebanzimanyi merged 1 commit intoAug 31, 2026
Merged
Conversation
`Dockerfile` built MobilityDB from `stable-1.3` while the jar it runs is generated from the catalog of master, and it built without `-DALL=ON`, so the library answered for a narrower family list than the surface the generator emits. It now clones master and passes `-DALL=ON`, the flag `CMakeLists.txt` turns into the family list. Its JMEOS step cloned the branch `fix-tests-using-docker` into `/usr/local/jmeos`, swapped a library into it and deleted its jars. Nothing in the image ever read that directory — the branch was pinned for a checkout no stage consumed. `COPY jar/JMEOS.jar` and the classpath entry beside it are the `systemPath` model `pom.xml` itself has commented out: the shade plugin includes `*:*`, and the 33 MB application jar carries `functions/GeneratedFunctions.class`. Both go, and `jar/` need not be assembled by hand before a build. `Dockerfile_q8_meos_kalman` existed to build `marianaGarcez/MobilityDB` and patch `temporal_ext_kalman_filter` into `functions.java` with two `sed` scripts. That entry is declared in `meos/include/meos.h` on upstream master, so the generator emits it and `meos/examples/ais_ekf_clean.c` is upstream as well. The image differed from the base one in nothing else, and `run_query.sh` already patches the entrypoint class it needed, so query 8 runs on the base image and the file goes with its `QUERY_DOCKERFILE` entry. The two `Query8_V2_Main` classes name the public MEOS entry rather than a fork. `mvn test` is green over the module: 12 tests, 0 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfilebuilt MobilityDB fromstable-1.3while the jar it runs isgenerated from the catalog of master, and it built without
-DALL=ON, so thelibrary answered for a narrower family list than the surface the generator
emits. It now clones master and passes
-DALL=ON, the flagCMakeLists.txtturns into the family list.
Its JMEOS step cloned the branch
fix-tests-using-dockerinto/usr/local/jmeos, swapped a library into it and deleted its jars. Nothing inthe image ever read that directory — the branch was pinned for a checkout no
stage consumed.
COPY jar/JMEOS.jarand the classpath entry beside it are thesystemPathmodelpom.xmlitself has commented out: the shade plugin includes*:*, and the 33 MB application jar carriesfunctions/GeneratedFunctions.class.Both go, and
jar/need not be assembled by hand before a build.Dockerfile_q8_meos_kalmanexisted to buildmarianaGarcez/MobilityDBand patchtemporal_ext_kalman_filterintofunctions.javawith twosedscripts.That entry is declared in
meos/include/meos.hon upstream master, so thegenerator emits it and
meos/examples/ais_ekf_clean.cis upstream as well. Theimage differed from the base one in nothing else, and
run_query.shalreadypatches the entrypoint class it needed, so query 8 runs on the base image and
the file goes with its
QUERY_DOCKERFILEentry. The twoQuery8_V2_Mainclasses name the public MEOS entry rather than a fork.
mvn testis green over the module: 12 tests, 0 skipped.