Wire the batch runners to the canonical BerlinMOD loaders - #59
Merged
estebanzimanyi merged 2 commits intoJul 22, 2026
Merged
estebanzimanyi merged 2 commits into
estebanzimanyi merged 2 commits into
Conversation
The shared batch queries used a divergent vehId / Query* schema that does not match the schema the canonical loaders produce. Rename the table and column references to the canonical names the merged loaders (berlinmod_load.sql and mobilityduck_load.sql) create — VehicleId, TripId, and the Instants, Periods, Points, Regions and Licences parameter relations — so the single query source is consistent with the canonical per-tool loaders every runner uses and with the classic berlinmod_r_queries_portable.sql query set.
bench_mbdb.sh and bench_mduck.sh read a load_*.sql loader and per-query qNN.sql files that are absent from the repository, so the batch benchmark cannot run. Wire each runner to reuse its canonical merged loader instead of a bespoke one: bench_mbdb.sh runs berlinmod_load.sql (SELECT berlinmod_load(dir, true)) and berlinmod_th3index_setup.sql; bench_mduck.sh runs mobilityduck_load.sql. Both read the shared queries by splitting the single queries.sql on its `-- @query` markers. The MobilityDuck query loop drops the search_path override, since the canonical loader creates its tables in the default (main) schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench_mbdb.shandbench_mduck.shread aload_*.sqlloader and per-queryqNN.sqlfiles that are absent from the repository, so the batch benchmark cannot run.Each runner reuses its canonical merged loader instead of a bespoke one:
bench_mbdb.shrunsberlinmod_load.sql(SELECT berlinmod_load(dir, true)) +berlinmod_th3index_setup.sql.bench_mduck.shrunsmobilityduck_load.sql.Both read the shared queries by splitting the single
queries.sqlon its-- @querymarkers. The MobilityDuck loop omits thesearch_pathoverride, since the canonical loader creates its tables in the defaultmainschema. The corpus is the canonicalbrussels_sf0.1dataset.