Align the batch benchmark queries to the canonical BerlinMOD schema - #58
Merged
estebanzimanyi merged 1 commit intoJul 22, 2026
Conversation
The shared batch queries used a divergent vehId / Query* schema that does not match the schema the canonical loaders produce. Rename the table and column references to the canonical names the merged loaders (berlinmod_load.sql and mobilityduck_load.sql) create — VehicleId, TripId, and the Instants, Periods, Points, Regions and Licences parameter relations — so the single query source is consistent with the canonical per-tool loaders every runner uses and with the classic berlinmod_r_queries_portable.sql query set.
estebanzimanyi
force-pushed
the
fix/batch-queries-canonical-schema
branch
from
July 22, 2026 19:37
96c06f4 to
065d2d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared batch queries in
benchmarks/batch/bench/queries.sqlreference avehId/Query*schema that does not match the schema the canonical loaders produce.This renames the table and column references to the canonical names the merged loaders create —
VehicleId,TripId, and theInstants/Periods/Points/Regionsparameter tables (QueryLicencesis already canonical), so the single query source is consistent with the canonical per-tool loaders every runner uses.The change is a pure identifier rename (61 lines, no query logic altered).