Make the MobilityDuck batch benchmark runner turnkey - #57
Closed
estebanzimanyi wants to merge 1 commit into
Closed
estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
The batch runner bench_mduck.sh reads a load_mduck.sql loader and per-query qNN.sql files that are absent from the repository, so the MobilityDuck side of the cross-platform benchmark cannot run. Add bench/load_mduck.sql, which loads the cross-platform portability export (the same vehicles/trips/query_*.csv the MobilityDB runner consumes) into the schema queries.sql expects: Trips and Vehicles plus the Query* selectors and the trip_h3 prefilter. SRID is resolved by MEOS parsers, never by hand: trips via tgeompointFromHexEWKB, static geometries via ST_GeomFromText (which accepts the SRID-tagged EWKT). Rewire bench_mduck.sh to read each query from the shared queries.sql, split on its "-- BerlinMOD Qn:" markers, and report queries the extension cannot run instead of recording phantom timings.
Member
Author
|
Closing per maintainer direction: this duplicates the canonical per-tool loading path. The batch runner should reuse MobilityDuck's own BerlinMOD loader rather than a separate hand-authored one over the portability-export CSVs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch runner
bench_mduck.shreads aload_mduck.sqlloader and per-queryqNN.sqlfiles that are absent from the repository, so the MobilityDuck side of the cross-platform batch benchmark cannot run.This makes the MobilityDuck side turnkey, mirroring the MobilityDB runner:
bench/load_mduck.sqlloads the cross-platform portability export — the samevehicles.csv/trips.csv/query_*.csvthe MobilityDB runner consumes — into the schemaqueries.sqlexpects:TripsandVehiclesplus theQuery*selectors and thetrip_h3prefilter column. SRID is resolved by MEOS parsers, never by hand: the trip viatgeompointFromHexEWKBand the static geometries viaST_GeomFromText(which accepts the SRID-tagged EWKT).bench_mduck.shreads each query from the sharedqueries.sql, split on its-- BerlinMOD Qn:markers, and reports any query the loaded extension cannot run instead of recording a phantom sub-second timing.At scale factor 0.005 (632 vehicles / 1620 trips) the data loads and every query the extension supports runs and times, including the h3 prefilter (
geoToH3IndexSet+eEq+eIntersects). A query that needs a function a given extension build does not expose (for examplegeoToH3Cellor theeDwithinPairsset-set join) is reported and excluded, so the harness is transparent about extension coverage rather than silently green.