Make the PostgreSQL batch benchmark runner turnkey - #56
Closed
estebanzimanyi wants to merge 2 commits into
Closed
estebanzimanyi wants to merge 2 commits into
estebanzimanyi wants to merge 2 commits into
Conversation
The batch runner bench_mbdb.sh reads a load_mbdb.sql loader and per-query qNN.sql files that are absent from the repository, so the MobilityDB side of the cross-platform benchmark cannot run. Add bench/load_mbdb.sql, which loads the cross-platform portability export (vehicles/trips/query_*.csv produced by berlinmod_portability_export) into the schema the shared queries.sql expects: Trips and Vehicles plus the Query* parameter selectors, the trip_h3 prefilter column, and the GiST/SP-GiST/th3 indexes the tier logic toggles. The trip trajectory is parsed from its hex-EWKB, and geomWKT is carried as the SRID-tagged EWKT text. Rewire bench_mbdb.sh to read each query from the shared queries.sql, split on its "-- BerlinMOD Qn:" markers, and surface query failures instead of recording phantom sub-second timings. Add setup/generate_data.sh, orchestrating berlinmod_generate and berlinmod_portability_export to produce the CSV corpus (default scale factor 0.005), closing the reference in bench.sh.
The Deploy documentation job is gated to master, so on every pull request it reports as a skipped check. Fold its gh-pages publish into the Generate documentation job as conditional steps guarded on a master push: a skipped step emits no check, so pull requests show a single always-green documentation check and no skipped deploy job. Deploy behaviour is unchanged.
Member
Author
|
Closing per maintainer direction: this duplicates the canonical loading path. The repository's own berlinmod_load.sql is the canonical PostgreSQL BerlinMOD loader; the batch runner should build on that rather than a separate hand-authored one over the portability-export CSVs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch runner
bench_mbdb.shreads aload_mbdb.sqlloader and per-queryqNN.sqlfiles that are absent from the repository, so the MobilityDB side of the cross-platform batch benchmark cannot run.This makes the PostgreSQL side turnkey:
bench/load_mbdb.sqlloads the cross-platform portability export (vehicles.csv/trips.csv/query_*.csvfromberlinmod_portability_export) into the schemaqueries.sqlexpects —TripsandVehiclesplus theQuery*parameter selectors, thetrip_h3prefilter column, and the GiST / SP-GiST / th3 indexes the tier logic toggles. The trip trajectory is parsed from its hex-EWKB;geomWKTis the SRID-tagged EWKT text.bench_mbdb.shreads each query from the sharedqueries.sql, split on its-- BerlinMOD Qn:markers, and surfaces query failures instead of recording phantom sub-second timings.setup/generate_data.shorchestratesberlinmod_generateandberlinmod_portability_exportto produce the CSV corpus (default scale factor 0.005), closing the reference inbench.sh.At scale factor 0.005 (1620 trips) all eighteen queries (q01–q17 + qrt) load and run under tier 3.