Skip to content

Use global fetch if in browser environment, else use cross-fetch #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njerig wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Use global fetch if in browser environment, else use cross-fetch #23

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0ab149b
Use global fetch in browser, else use cross-fetch
njerig Apr 3, 2023
e42e6a3
Remove isomorphic-fetch from dependencies
njerig Apr 3, 2023
20754b0
Remove DOM lib from TS config
njerig Apr 3, 2023
5ebf326
Make my own NPM package
njerig Sep 8, 2023
f65e9d4
Add timeout option and initialization function
njerig Oct 28, 2023
a5302a6
Add initialization function to README
njerig Oct 28, 2023
3b5a256
Bump version up to v0.1.1
njerig Oct 28, 2023
65cea72
Fix timeout
njerig Oct 28, 2023
1697108
Bump version up to v0.1.2
njerig Oct 28, 2023
b0a799f
Correct types and add more support for timeout
njerig Oct 29, 2023
ca88647
Bump version up to v0.1.3
njerig Oct 29, 2023
4dcd099
Implement getDepartments function
njerig Oct 31, 2023
41e5da0
Implement getTeachersByDepartment function
njerig Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@
]
},
"dependencies": {
"@types/isomorphic-fetch": "^0.0.36",
"graphql": "^15.4.0",
"graphql-request": "^3.4.0",
"isomorphic-fetch": "^3.0.0"
"graphql-request": "^3.4.0"
},
"ava": {
"files": [
Expand Down
4 changes: 2 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import {GraphQLClient} from 'graphql-request';
import fetch from 'isomorphic-fetch';
import {fetch as crossFetch} from 'cross-fetch';
Comment thread
njerig marked this conversation as resolved.
import {autocompleteSchoolQuery, searchTeacherQuery, getTeacherQuery} from './queries';
import {AUTH_TOKEN} from './constants';

const client = new GraphQLClient('https://www.ratemyprofessors.com/graphql', {
headers: {
authorization: `Basic ${AUTH_TOKEN}`
},
fetch
fetch: globalThis.fetch ?? crossFetch
});

export interface ISchoolFromSearch {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"lib": ["ES2017", "DOM"],
"lib": ["ES2017"],
"target": "es6",
"module": "commonjs",
"declaration": true,
Expand Down
Loading