Conversation
- The output already has a tree in the scene_output it doesn't need another one. - Outputs aren't focused by default on connection anymore, that is now controlled by the server. - Output configurations (used in programs such as wlr-randr) are now configured in the root - Layers are now cropped to their outputs size - arranging the layers of an output won't affect other layers in other outputs
EggbertFluffle
approved these changes
May 17, 2026
| else => continue, | ||
| }; | ||
|
|
||
| if (layer_surface.output.wlr_output != self.wlr_output) continue; |
Collaborator
There was a problem hiding this comment.
Wouldn't this mean that a layer surface is currently a child of the wrong output and this is an incorrect state? Perhaps fix it or error?
Member
Author
There was a problem hiding this comment.
Maybe, I think we need to do some testing to figure out what would be best. I'll add a todo to the codebase.
| } | ||
|
|
||
| pub fn focusOutput(self: *Seat, output: *Output) void { | ||
| if (self.focused_output) |prev_output| { |
Collaborator
There was a problem hiding this comment.
I like not having to set the state of individual outputs, good stuff
| return; | ||
| }; | ||
|
|
||
| // TODO: Allow user to define output positions |
Collaborator
There was a problem hiding this comment.
Perhaps to do this we could use an autocommand that simply returns the output's position? Just a though, no need to do this to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superseeds #46
closes #33