Skip to content

Waited for canplay event before playing after seek #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mauro1855 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Waited for canplay event before playing after seek #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/VideoPlayer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ const hooks = {
state.playing = false
},
seeked() {
state.playAfterSeek === true && videoPlayerPlugin.play()
state.playAfterSeek &&
videoEl.addEventListener('canplay', () => videoPlayerPlugin.play(), { once: true })
Copy link
Copy Markdown
Collaborator

@Thomvl Thomvl Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure all browsers actually fire the correct 'canplay' event?
Don't we need some fallback? like firing play immediately, but also on canplay?

Copy link
Copy Markdown
Contributor

@robbertvancaem robbertvancaem Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the support is very good: https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/canplay_event#browser_compatibility

Copy link
Copy Markdown
Author

@mauro1855 mauro1855 Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original SDK code replaced in this PR doesn't really work as expected (as indicated in #5) according to some tests I did in the past. This fix solved the issue, but I didn't test it exhaustively. I would suggest double-checking this in some STBs.

state.playAfterSeek = null
},
abort() {
Expand Down Expand Up @@ -442,7 +443,10 @@ const videoPlayerPlugin = {

export default autoSetupMixin(videoPlayerPlugin, () => {
precision =
(ApplicationInstance && ApplicationInstance.stage && ApplicationInstance.stage.getRenderPrecision()) || precision
(ApplicationInstance &&
ApplicationInstance.stage &&
ApplicationInstance.stage.getRenderPrecision()) ||
precision
Copy link
Copy Markdown
Collaborator

@Thomvl Thomvl Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like just linebreaks which has nothing to do with the initial issue, correct?

Copy link
Copy Markdown
Author

@mauro1855 mauro1855 Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you are correct.


videoEl = setupVideoTag()

Expand Down