feat: re-lock on download failure#247
Open
dsteeley wants to merge 4 commits into
Open
Conversation
When pinned packages are removed from a rolling repo (e.g. UBI9 only retains the latest package version), rpmoci build fails at download time with "Package could no longer be found in repositories". The error was correct but gave no guidance on how to resolve it. Add context to the lockfile.build() call so failures include a suggestion to run `rpmoci update` to regenerate the lock file. Fixes: DEVX-544
…fails. Intended to resolve issues where a compatible lockfile is invalid due to upstream OS packages being removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running rpmoci (specifically on ubi9 rpm repos) there is a class of error where the lockfile is valid but the rpms referenced in the lockfile are no longer present in the rpm repos specified.
This PR attempts to address the above issue by regenerating the lockfile when running an unlocked build with a valid lockfile.
The downside of this is that lockfile regeneration will occur when an unlocked valid lockfile build fails for any reason.