Skip to content

test fx: Do not crash when node data has already been downloaded #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kukks wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −1
Open

test fx: Do not crash when node data has already been downloaded #1100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df10b49
test fx: Do not crash when node data has already been downloaded
Kukks May 30, 2022
3f7a0b9
Update NBitcoin.TestFramework/NodeBuilder.cs
Kukks May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NBitcoin.TestFramework/NBitcoin.TestFramework.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

<ItemGroup>
<ProjectReference Include="..\NBitcoin\NBitcoin.csproj" />
<PackageReference Include="System.IO.Compression" Version="4.3.0" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />
</ItemGroup>

Expand Down
12 changes: 11 additions & 1 deletion NBitcoin.TestFramework/NodeBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,17 @@ public static string EnsureDownloaded(NodeDownloadData downloadData)

if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
ZipFile.ExtractToDirectory(zip, extractDirectory);
//from https://feedback.telerik.com/document-processing/1518667-ziplibrary-allow-zipfile-extracttodirectory-to-overwrite-existing-files-when-extract-zip
Comment thread
Kukks marked this conversation as resolved.
Outdated
using var source = ZipFile.Open(zip, ZipArchiveMode.Read, null);
foreach (var entry in source.Entries)
{
var fullPath = Path.GetFullPath(Path.Combine(extractDirectory, entry.FullName));

if (Path.GetFileName(fullPath).Length == 0) continue;
Directory.CreateDirectory(Path.GetDirectoryName(fullPath));
// The boolean parameter determines whether an existing file that has the same name as the destination file should be overwritten
entry.ExtractToFile(fullPath, true);
}
}
else
{
Expand Down