Skip to content

Add JCC (JiuCaiBi) BEP-20 token#1787

Open
simonkang123 wants to merge 2 commits intoMetaMask:masterfrom
simonkang123:add-jcc-token
Open

Add JCC (JiuCaiBi) BEP-20 token#1787
simonkang123 wants to merge 2 commits intoMetaMask:masterfrom
simonkang123:add-jcc-token

Conversation

@simonkang123
Copy link
Copy Markdown

@simonkang123 simonkang123 commented Apr 20, 2026

Adding JCC (JiuCaiBi) to MetaMask contract metadata.

Field Value
Contract 0x992c30DD833E65586c6CEe32686dBE0cdCA077cc
Symbol JCC
Decimals 18
Chain BNB Smart Chain

Note

Low Risk
Low risk data-only change that adds a new token entry; main risk is incorrect contract metadata (address/symbol/decimals/logo) affecting display in wallets.

Overview
Adds MetaMask contract metadata for the JCC (JiuCaiBi) token at 0x992c30DD833E65586c6CEe32686dBE0cdCA077cc (name, symbol, decimals, and jcc.png logo reference) to contract-map.json.

Also cleans up minor JSON formatting artifacts and adjusts the file ending (newline/closing braces).

Reviewed by Cursor Bugbot for commit 30321c0. Bugbot is set up for automated code reviews on this repo. Configure here.

@simonkang123 simonkang123 requested review from a team and MRabenda as code owners April 20, 2026 03:51
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 30321c0. Configure here.

Comment thread contract-map.json
"logo": "jcc.png",
"erc20": true,
"symbol": "JCC",
"decimals": 18
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEP-20 token incorrectly added to Ethereum mainnet registry

High Severity

The PR description states JCC is a BEP-20 token on BNB Smart Chain (chain 56), but it's added to contract-map.json, which is the Ethereum mainnet (chain 1) token registry. All other entries in this file are Ethereum ERC-20 tokens. BNB Smart Chain tokens belong in metadata/eip155:56/ as individual JSON files, following the CAIP-19 standard used throughout the repository. This will cause MetaMask to incorrectly present JCC as an Ethereum mainnet token.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 30321c0. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant