Add JCC (JiuCaiBi) BEP-20 token#1787
Open
simonkang123 wants to merge 2 commits intoMetaMask:masterfrom
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 30321c0. Configure here.
| "logo": "jcc.png", | ||
| "erc20": true, | ||
| "symbol": "JCC", | ||
| "decimals": 18 |
There was a problem hiding this comment.
BEP-20 token incorrectly added to Ethereum mainnet registry
High Severity
The PR description states JCC is a BEP-20 token on BNB Smart Chain (chain 56), but it's added to contract-map.json, which is the Ethereum mainnet (chain 1) token registry. All other entries in this file are Ethereum ERC-20 tokens. BNB Smart Chain tokens belong in metadata/eip155:56/ as individual JSON files, following the CAIP-19 standard used throughout the repository. This will cause MetaMask to incorrectly present JCC as an Ethereum mainnet token.
Reviewed by Cursor Bugbot for commit 30321c0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adding JCC (JiuCaiBi) to MetaMask contract metadata.
Note
Low Risk
Low risk data-only change that adds a new token entry; main risk is incorrect contract metadata (address/symbol/decimals/logo) affecting display in wallets.
Overview
Adds MetaMask contract metadata for the
JCC(JiuCaiBi) token at0x992c30DD833E65586c6CEe32686dBE0cdCA077cc(name, symbol, decimals, andjcc.pnglogo reference) tocontract-map.json.Also cleans up minor JSON formatting artifacts and adjusts the file ending (newline/closing braces).
Reviewed by Cursor Bugbot for commit 30321c0. Bugbot is set up for automated code reviews on this repo. Configure here.