Replace 64-bit clim_gal9 nrun-crun test with 32-bit version#541
Open
Steve Mullerworth (stevemullerworth) wants to merge 2 commits into
Open
Replace 64-bit clim_gal9 nrun-crun test with 32-bit version#541Steve Mullerworth (stevemullerworth) wants to merge 2 commits into
Steve Mullerworth (stevemullerworth) wants to merge 2 commits into
Conversation
iboutle
approved these changes
Jun 5, 2026
iboutle
left a comment
Contributor
There was a problem hiding this comment.
Almost trivial - looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: iboutle
Code Reviewer:
This test strengthens testing for tickets that went in at 3.2, but could only be done once both those tickets were on main - it would be useful to get this small change on for 3.2.
The default precision for scientific evaluation of
clim_gal9is 32-bit, and till recently rose-stem tested this configuration at 32-bit.The test was changed to 64-bit as part of #383 in order to add a test for reproducibility across nrun-crun boundaries as that PR did not fix a further issue that prevented nrun-crun reproducibility when running at 32-bit.
PR #427 (fixing checkpointing of the random seed when running with 32-bit precision) fixed this second issue, but was done in parallel with #383 meaning the nrun-crun test was not included in the branch.
Now both PRs are done, this PR can revert the
clim_gal9test to 32-bit (as advised in the prior PRs) while still also testing for nrun-v-crun reproducibility.Change includes replacing of the 64-bit checksums with 32-bit checksums for the modified job. As there are no science changes, I ran just the developer group.
iboutle CC:d as code owner - hopefully OK to sign of science review.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - clim_gal9_r32_chkpt_forpr/run1
Suite Information
Task Information
✅ succeeded tasks - 1196
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review