Skip to content

Fix mistaken uses of splitting fraction #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thomas Bendall (tommbendall) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix mistaken uses of splitting fraction #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a7b1fc
Merge pull request #5 from MetOffice/stable
tommbendall Mar 9, 2026
c89a744
fix splitting fraction error
tommbendall Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions science/gungho/source/algorithm/transport/ffsl/ffsl_control_alg_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module ffsl_control_alg_mod
use flux_precomputations_alg_mod, only: flux_precomputations_type
use split_transport_utils_mod, only: get_num_split_steps, &
get_splitting_direction, &
get_splitting_fraction
get_splitting_factor
use transport_controller_mod, only: transport_controller_type
use transport_counter_mod, only: transport_counter_type
use transport_enumerated_types_mod, only: direction_v, &
Expand Down Expand Up @@ -110,7 +110,7 @@ contains
)

! Get time step
dt_frac = get_splitting_fraction( &
dt_frac = get_splitting_factor( &
transport_metadata%get_splitting(), &
transport_counter%get_split_step_of_substep_counter() &
)
Expand Down
4 changes: 2 additions & 2 deletions science/gungho/source/algorithm/transport/sl/horizontal_sl_advective_alg_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module horizontal_sl_advective_alg_mod

! Transport control
use flux_precomputations_alg_mod, only: flux_precomputations_type
use split_transport_utils_mod, only: get_splitting_fraction, &
use split_transport_utils_mod, only: get_splitting_factor, &
get_dry_config
use transport_controller_mod, only: transport_controller_type
use transport_counter_mod, only: transport_counter_type
Expand Down Expand Up @@ -150,7 +150,7 @@ module horizontal_sl_advective_alg_mod
transport_metadata => transport_controller%get_transport_metadata()

! Get time step
dt_frac = get_splitting_fraction( &
dt_frac = get_splitting_factor( &
transport_metadata%get_splitting(), &
transport_counter%get_split_step_of_substep_counter() &
)
Expand Down
Loading